feat(stream): skip sending snapshot when client digest matches#5909
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #5909 +/- ##
==========================================
+ Coverage 61.19% 61.29% +0.09%
==========================================
Files 141 141
Lines 14195 14211 +16
==========================================
+ Hits 8686 8710 +24
+ Misses 4777 4772 -5
+ Partials 732 729 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
approved these changes
May 25, 2026
markphelps
left a comment
Collaborator
There was a problem hiding this comment.
thank you! just one minor error message change
Short-circuit stream send when client's last digest matches snapshot, reducing redundant data transfer for OFREP clients Signed-off-by: Roman Dmytrenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-circuit stream send when client's last digest matches snapshot,
reducing redundant data transfer for OFREP clients