Skip to content

feat(stream): skip sending snapshot when client digest matches#5909

Merged
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/sse-update
May 25, 2026
Merged

feat(stream): skip sending snapshot when client digest matches#5909
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/sse-update

Conversation

@erka

@erka erka commented May 25, 2026

Copy link
Copy Markdown
Contributor

Short-circuit stream send when client's last digest matches snapshot,
reducing redundant data transfer for OFREP clients

@erka
erka requested a review from a team as a code owner May 25, 2026 17:39
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 25, 2026
@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 25, 2026, 8:13 PM

@erka erka added the v2 Flipt v2 label May 25, 2026
@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.29%. Comparing base (86632ae) to head (7778342).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/cmd/grpc.go 83.33% 2 Missing ⚠️
internal/gateway/gateway.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #5909      +/-   ##
==========================================
+ Coverage   61.19%   61.29%   +0.09%     
==========================================
  Files         141      141              
  Lines       14195    14211      +16     
==========================================
+ Hits         8686     8710      +24     
+ Misses       4777     4772       -5     
+ Partials      732      729       -3     
Flag Coverage Δ
integrationtests 34.51% <43.58%> (+0.02%) ⬆️
unittests 52.38% <64.10%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! just one minor error message change

Comment thread internal/gateway/gateway.go Outdated
Short-circuit stream send when client's last digest matches snapshot,
reducing redundant data transfer for OFREP clients

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka
erka force-pushed the rd/v2/sse-update branch from 8d1af4f to 7778342 Compare May 25, 2026 19:40
@erka erka added the automerge Used by Kodiak bot to automerge PRs label May 25, 2026
@kodiakhq
kodiakhq Bot merged commit 95b8f4d into v2 May 25, 2026
40 of 41 checks passed
@kodiakhq
kodiakhq Bot deleted the rd/v2/sse-update branch May 25, 2026 20:13
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:L This PR changes 100-499 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants