Skip to content

fix(authn): add HttpOnly and Secure attrs when clearing auth cookies#5655

Merged
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/codeql-cookie
Apr 2, 2026
Merged

fix(authn): add HttpOnly and Secure attrs when clearing auth cookies#5655
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/codeql-cookie

Conversation

@erka

@erka erka commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Address CodeQL reports

Address CodeQL reports

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka
erka requested a review from a team as a code owner April 2, 2026 17:24
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 2, 2026
@codecov

codecov Bot commented Apr 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.71%. Comparing base (f67ee5f) to head (d1e3405).
⚠️ Report is 2 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #5655   +/-   ##
=======================================
  Coverage   60.70%   60.71%           
=======================================
  Files         141      141           
  Lines       14023    14025    +2     
=======================================
+ Hits         8513     8515    +2     
  Misses       4784     4784           
  Partials      726      726           
Flag Coverage Δ
integrationtests 34.53% <0.00%> (-0.01%) ⬇️
unittests 51.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka added the v2 Flipt v2 label Apr 2, 2026
@erka erka added the automerge Used by Kodiak bot to automerge PRs label Apr 2, 2026
@kodiakhq
kodiakhq Bot merged commit 3462b64 into v2 Apr 2, 2026
36 checks passed
@kodiakhq
kodiakhq Bot deleted the rd/v2/codeql-cookie branch April 2, 2026 20:04
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:S This PR changes 10-29 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants