fix: address CodeQL warning about insecure TLS configuration#5614
Merged
Conversation
Replace InsecureSkipVerify: true with proper CA certificate handling for Azure secrets emulator tests. Extract and install the vault's CA certificate into test containers. Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5614 +/- ##
==========================================
- Coverage 60.68% 60.65% -0.03%
==========================================
Files 141 141
Lines 13998 13989 -9
==========================================
- Hits 8494 8485 -9
Misses 4780 4780
Partials 724 724
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
approved these changes
Mar 26, 2026
|
Documentation Updates 1 document(s) were updated by changes in this PR: Secrets Management SystemView Changes@@ -156,7 +156,7 @@
Secret references use the format `${secret:azure:secret-name}`, where `secret-name` is the name of the secret in Azure Key Vault.
**Emulator Support:**
-For integration testing, you can use the `AZURE_KEYVAULT_EMULATOR` environment variable to connect to emulator services like [Lowkey Vault](https://github.com/nagyesta/lowkey-vault). When this variable is set, the provider skips TLS verification and uses a fake credential for authentication.
+For integration testing, you can use the `AZURE_KEYVAULT_EMULATOR` environment variable to connect to emulator services like [Lowkey Vault](https://github.com/nagyesta/lowkey-vault). When this variable is set, the provider uses a fake credential for authentication while still maintaining proper TLS certificate validation.
## Provider Setup
To enable a provider, set its `enabled` flag to `true` and provide the necessary configuration options. For the file provider, specify the `base_path` to your secrets file. For the Vault provider, specify the Vault server address, authentication method, token, and mount path. For the AWS provider, specify the AWS region and optionally a custom endpoint URL for testing. For the GCP provider, specify the GCP project ID and optionally a service account credentials file. For the Azure provider, specify the Azure Key Vault URL. You can use environment variables for sensitive values by referencing them with `${env:VAR}`.How did I do? Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace InsecureSkipVerify: true with proper CA certificate handling
for Azure secrets emulator tests. Extract and install the vault's CA
certificate into test containers.