Skip to content

feat: publish v2 protobufs to buf.build/flipt-io/v2#5589

Merged
markphelps merged 1 commit into
v2from
feat/buf-v2-publish
Mar 20, 2026
Merged

feat: publish v2 protobufs to buf.build/flipt-io/v2#5589
markphelps merged 1 commit into
v2from
feat/buf-v2-publish

Conversation

@markphelps

Copy link
Copy Markdown
Collaborator

Summary

Publish Flipt v2 protobufs under a dedicated Buf module without impacting v1.

Changes

  • Update buf.yaml to publish all v2 protos as one module:
    • path: rpc/v2
    • name: buf.build/flipt-io/v2
  • Enable v2* tag workflow in .github/workflows/proto-push.yml to:
    • lint rpc/v2
    • run breaking checks for rpc/v2 against branch=v2
    • push rpc/v2 using BUF_TOKEN

Notes

  • Keeps buf.build/flipt-io/flipt unchanged.
  • Implemented on branch feat/buf-v2-publish in response to paperclip follow-up.

@markphelps
markphelps requested a review from a team as a code owner March 20, 2026 01:05
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @markphelps! Thanks for your contribution to this project.

It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license.

How to fix this:

# For future commits, use the -s flag
git commit -s -m "Your commit message"

# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-lease

The -s flag adds this line to your commit message:
Signed-off-by: Your Name <[email protected]>

📋 View the failing DCO check for more details

For more information about the DCO, visit: https://developercertificate.org/

@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.40%. Comparing base (dd02c14) to head (f7fd0f9).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #5589   +/-   ##
=======================================
  Coverage   60.40%   60.40%           
=======================================
  Files         141      141           
  Lines       13998    13998           
=======================================
  Hits         8456     8456           
  Misses       4821     4821           
  Partials      721      721           
Flag Coverage Δ
integrationtests 34.35% <ø> (ø)
unittests 51.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@markphelps
markphelps merged commit eddfb54 into v2 Mar 20, 2026
33 of 34 checks passed
@markphelps
markphelps deleted the feat/buf-v2-publish branch March 20, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants