fix: snapshot publisher subs and correct constraint short-circuiting#5565
Merged
Conversation
erka
commented
Mar 15, 2026
erka
commented
Contributor
- Deep-copy subscriptions under lock before publishing
- Use labeled breaks to short-circuit constraint evaluation safely
- Deep-copy subscriptions under lock before publishing - Use labeled breaks to short-circuit constraint evaluation safely Signed-off-by: Roman Dmytrenko <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5565 +/- ##
==========================================
- Coverage 60.40% 60.39% -0.01%
==========================================
Files 141 141
Lines 13995 13993 -2
==========================================
- Hits 8453 8451 -2
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
marked this pull request as ready for review
March 15, 2026 23:19
dosubot
Bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.