fix(sdk): add Content-Type header and improve error messages in generated HTTP client#5560
Merged
Conversation
…ated HTTP client - Fix race condition in KubernetesAuthenticationProvider.Authentication() using local resp instead of k.resp after read lock - Add Content-Type: application/json to all SDK HTTP requests - Improve error messages to include HTTP status and response body Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:S
Contributor
|
The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).
|
erka
marked this pull request as draft
March 13, 2026 21:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5560 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 141 141
Lines 13995 13995
=======================================
Hits 8453 8453
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
rd/v2/sdk-issue
branch
3 times, most recently
from
March 14, 2026 10:56
7c796be to
a8e2d96
Compare
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
marked this pull request as ready for review
March 14, 2026 11:48
dosubot
Bot
added
size:XL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using local resp instead of k.resp after read lock