chore: migrate goreleaser configs to dockers_v2 and homebrew_casks#5508
Merged
kodiakhq[bot] merged 1 commit intoMar 9, 2026
Conversation
costajohnt
marked this pull request as ready for review
March 7, 2026 20:23
dosubot
Bot
added
the
size:L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5508 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 141 141
Lines 13995 13995
=======================================
Hits 8453 8453
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace deprecated `dockers` + `docker_manifests` with `dockers_v2` in both `.goreleaser.yml` and `.goreleaser.nightly.yml`. The new config produces identical multi-arch Docker images and manifests with significantly less boilerplate. Replace deprecated `brews` with `homebrew_casks` in `.goreleaser.yml`. Binary installation uses the cask-native `binaries` field. Shell completions, the Homebrew service definition, and post_install log directory creation are dropped — these formula-specific features need different approaches in casks (e.g. pre-generated completion files in the archive, launchd plists) and can be added as follow-ups. Closes #5503 Signed-off-by: John Costa <[email protected]>
markphelps
approved these changes
Mar 9, 2026
markphelps
left a comment
markphelps
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. thank you @costajohnt !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dockers+docker_manifestswithdockers_v2in.goreleaser.ymland.goreleaser.nightly.ymlbrewswithhomebrew_casksin.goreleaser.ymlCloses #5503
Changes
Docker (
dockers_v2)The two per-architecture
dockersentries and separatedocker_manifestsentries are consolidated into a singledockers_v2block. GoReleaser handles per-platform builds and manifest creation internally. The resulting Docker images, tags, and multi-arch manifests are identical:flipt/flipt:v{tag},flipt/flipt:v{major}(amd64 + arm64 manifests)ghcr.io/flipt-io/flipt:v{tag},ghcr.io/flipt-io/flipt:v{major}(amd64 + arm64 manifests){version}tag on both registriesOCI labels are preserved via the
labels:map (replacing--label=inbuild_flag_templates).Homebrew (
homebrew_casks)The
brewssection is replaced withhomebrew_casks. Binary installation uses the cask-nativebinaries: [flipt]field.Intentionally dropped (need different approaches in casks):
Utils.popen_read. The caskcompletions:field requires pre-generated files in the release archive. Could be added as a follow-up by generating completion files during the build and including them inarchives.files.service:field references a.servicefile rather than using a Ruby DSL block.(var/"log/flipt").mkpathwas formula-specific. Could be added viahooks.post.installif needed.Not changed
build/Dockerfile— no changes needed;dockers_v2handles per-platform binary staging.goreleaser.darwin.yml,.goreleaser.linux.yml— build-only configs with no deprecated sectionsTesting
.Tag,.Major,.Version) correctly account formonorepo.tag_prefix: v