fix: set EnvironmentKey on evaluation requests in environment integration tests#5499
Merged
Conversation
…tion tests The evaluation requests were missing EnvironmentKey, causing them to always evaluate against the default environment. Since Go map iteration order is random, when the "production" environment test ran before "default", the flags didn't exist in the default environment yet, resulting in intermittent "not found" errors. Fixes #5413 Signed-off-by: Mark Phelps <[email protected]>
dosubot
Bot
added
the
size:S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5499 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 141 141
Lines 13995 13995
=======================================
Hits 8453 8453
Misses 4821 4821
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envsandenvs/dir) caused by evaluation requests not specifyingEnvironmentKeyChanges
build/testing/integration/environments/api_test.go: AddedEnvironmentKey: envto theVariantandBooleanevaluation requests so they evaluate against the correct environment being testedFixes #5413