Skip to content

fix(ui): sanitize generated keys and show key validation errors on first edit#5434

Merged
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/improve-generate-keys
Feb 27, 2026
Merged

fix(ui): sanitize generated keys and show key validation errors on first edit#5434
kodiakhq[bot] merged 1 commit into
v2from
rd/v2/improve-generate-keys

Conversation

@erka

@erka erka commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

closes #5432

@erka
erka requested a review from a team as a code owner February 27, 2026 13:43
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 27, 2026
@dosubot

dosubot Bot commented Feb 27, 2026

Copy link
Copy Markdown

Related Documentation

Checked 4 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@erka erka added v2 Flipt v2 labels Feb 27, 2026
@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (4fc0b65) to head (cab1ff6).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #5434   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         140      140           
  Lines       13906    13906           
=======================================
  Hits         8394     8394           
  Misses       4796     4796           
  Partials      716      716           
Flag Coverage Δ
integrationtests 34.17% <ø> (+0.01%) ⬆️
unittests 51.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka added automerge Used by Kodiak bot to automerge PRs labels Feb 27, 2026

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one ty

@kodiakhq
kodiakhq Bot merged commit 660efb9 into v2 Feb 27, 2026
38 checks passed
@kodiakhq
kodiakhq Bot deleted the rd/v2/improve-generate-keys branch February 27, 2026 14:35
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:S This PR changes 10-29 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UI: Missing validation error when flag contains invalid characters

2 participants