fix(ui): Toggle remove bg-brand class for unchecked state#5430
Conversation
|
👋 Hi @naftali100! Thanks for your contribution to this project. It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license. How to fix this: # For future commits, use the -s flag
git commit -s -m "Your commit message"
# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-leaseThe 📋 View the failing DCO check for more details For more information about the DCO, visit: https://developercertificate.org/ |
Signed-off-by: naftali <[email protected]>
|
It might be worth adjusting the default unchecked background in Switch.tsx. The contrast seems a bit low, and some users may have trouble noticing it. That was probably the reason the brand color was used there. |
|
how about |
|
Yeah... something like |
Signed-off-by: naftali <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5430 +/- ##
=======================================
Coverage 60.36% 60.36%
=======================================
Files 140 140
Lines 13906 13906
=======================================
Hits 8394 8394
Misses 4796 4796
Partials 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|


fixes: #5429
remove the brand class to fallback to the switch's
data-[state=unchecked]:bg-input