Skip to content

fix(ui): Toggle remove bg-brand class for unchecked state#5430

Merged
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
naftali100:v2
Feb 26, 2026
Merged

fix(ui): Toggle remove bg-brand class for unchecked state#5430
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
naftali100:v2

Conversation

@naftali100

@naftali100 naftali100 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

fixes: #5429

remove the brand class to fallback to the switch's data-[state=unchecked]:bg-input

@naftali100
naftali100 requested a review from a team as a code owner February 25, 2026 22:20
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @naftali100! Thanks for your contribution to this project.

It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license.

How to fix this:

# For future commits, use the -s flag
git commit -s -m "Your commit message"

# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-lease

The -s flag adds this line to your commit message:
Signed-off-by: Your Name <[email protected]>

📋 View the failing DCO check for more details

For more information about the DCO, visit: https://developercertificate.org/

@dosubot

dosubot Bot commented Feb 25, 2026

Copy link
Copy Markdown

Related Documentation

Checked 4 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@erka

erka commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

It might be worth adjusting the default unchecked background in Switch.tsx. The contrast seems a bit low, and some users may have trouble noticing it. That was probably the reason the brand color was used there.

@naftali100

naftali100 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

how about muted-foreground? is it contrasted enough?

@erka

erka commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Yeah... something like bg-muted-foreground/60' could be an option

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @naftali100

@erka

erka commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

new look
light theme
image
dark theme
image

@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (2917a74) to head (5359168).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #5430   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         140      140           
  Lines       13906    13906           
=======================================
  Hits         8394     8394           
  Misses       4796     4796           
  Partials      716      716           
Flag Coverage Δ
integrationtests 34.17% <ø> (ø)
unittests 51.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka
erka requested a review from markphelps February 25, 2026 23:30
@erka erka added the v2 Flipt v2 label Feb 25, 2026

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @naftali100 !!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Feb 26, 2026
@kodiakhq
kodiakhq Bot merged commit ac78eea into flipt-io:v2 Feb 26, 2026
42 of 43 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:XS This PR changes 0-9 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

better background color for toggle component

3 participants