fix(ci): bump Go version to 1.26 in nightly release workflow#5407
Merged
Conversation
The go.mod now requires go >= 1.26.0, but the nightly workflow was pinned to GO_VERSION 1.25 with GOTOOLCHAIN=local, causing magefiles to fail to compile. Signed-off-by: Mark Phelps <[email protected]>
dosubot
Bot
added
the
size:XS
|
Related Documentation Checked 4 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5407 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 139 139
Lines 13820 13820
=======================================
Hits 8347 8347
Misses 4763 4763
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
added a commit
that referenced
this pull request
Feb 21, 2026
…o/flipt into feat/aws-secrets-manager * 'feat/aws-secrets-manager' of https://github.com/flipt-io/flipt: fix(ui): use 0 as default threshold percentage in quick edit form (#5408) fix(ci): bump Go version to 1.26 in nightly release workflow (#5407)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly release workflow was failing because
go.modrequiresgo >= 1.26.0but the workflow was pinned toGO_VERSION: "1.25"withGOTOOLCHAIN=local, preventing automatic toolchain download and causing magefiles to fail to compile.Changes
.github/workflows/nightly.yml: UpdatedGO_VERSIONfrom1.25to1.26Additional Notes
Fixes the failure seen in https://github.com/flipt-io/flipt/actions/runs/22160727197/job/64076498641