fix: handle annual license key format in activation wizard#5335
Merged
Conversation
dosubot
Bot
added
the
size:L
|
Related Documentation Checked 2 published document(s) in 0 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #5335 +/- ##
==========================================
- Coverage 60.54% 60.53% -0.01%
==========================================
Files 138 138
Lines 13509 13531 +22
==========================================
+ Hits 8179 8191 +12
- Misses 4641 4651 +10
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
force-pushed
the
fix-license-activate
branch
from
January 30, 2026 15:01
a1fbc2d to
289c31b
Compare
The license key validation was hardcoded for monthly key format (XXXXXX-XXXXXX-XXXXXX-XXXXXX-XXXXXX-V3), but annual keys use a completely different format (key/<base64-payload>.<base64-signature>). - Show correct format guidance and placeholder based on license type - Validate annual keys check for 'key/' prefix and '.' separator - Extract validation into testable validateLicenseKey function - Add comprehensive test coverage for both key formats Signed-off-by: Mark Phelps <[email protected]>
markphelps
force-pushed
the
fix-license-activate
branch
from
January 30, 2026 15:04
289c31b to
aa92391
Compare
erka
pushed a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key/<base64-payload>.<base64-signature>) in addition to monthly keys (XXXXXX-XXXXXX-XXXXXX-XXXXXX-XXXXXX-V3)validateLicenseKeyfunction with test coverage