Skip to content

fix: support ssh URLs with non-standard ports in git#5298

Merged
erka merged 1 commit into
v2from
rd/v2/ssh-custom-port
Jan 26, 2026
Merged

fix: support ssh URLs with non-standard ports in git#5298
erka merged 1 commit into
v2from
rd/v2/ssh-custom-port

Conversation

@erka

@erka erka commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

related #5946

@erka
erka requested a review from a team as a code owner January 20, 2026 23:38
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 20, 2026
@dosubot

dosubot Bot commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Related Documentation

Checked 2 published document(s) in 0 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov

codecov Bot commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.53%. Comparing base (bf88830) to head (edd76de).
⚠️ Report is 12 commits behind head on v2.

Files with missing lines Patch % Lines
internal/coss/storage/environments/git/url.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##               v2    #5298   +/-   ##
=======================================
  Coverage   60.53%   60.53%           
=======================================
  Files         138      138           
  Lines       13504    13505    +1     
=======================================
+ Hits         8174     8175    +1     
  Misses       4641     4641           
  Partials      689      689
Flag Coverage Δ
integrationtests 34.67% <0.00%> (-0.01%) ⬇️
unittests 51.81% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka added the v2 Flipt v2 label Jan 22, 2026
GeorgeMac
GeorgeMac approved these changes Jan 26, 2026
View reviewed changes

@GeorgeMac GeorgeMac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do my approvals still carry any weight? 😂 Let's see.

@erka
erka merged commit da550d9 into v2 Jan 26, 2026
32 checks passed
@erka
erka deleted the rd/v2/ssh-custom-port branch January 26, 2026 11:22
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Jan 26, 2026
@erka

erka commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

@GeorgeMac thanks

@erka erka mentioned this pull request May 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees

No one assigned

Labels

size:S This PR changes 10-29 lines, ignoring generated files. v2 Flipt v2

Projects

Flipt V2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erka @GeorgeMac