Skip to content

refactor: migrate from go-grpc-prometheus to go-grpc-middleware/providers/prometheus#5272

Merged
markphelps merged 3 commits into
v2from
rd/v2/grpc-prometheus
Jan 31, 2026
Merged

refactor: migrate from go-grpc-prometheus to go-grpc-middleware/providers/prometheus#5272
markphelps merged 3 commits into
v2from
rd/v2/grpc-prometheus

Conversation

@erka

@erka erka commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

go-grpc-prometheus is depreacted and archived

…ders/prometheus

go-grpc-prometheus is depreacted and archived

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka
erka requested a review from a team as a code owner January 13, 2026 21:21
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2026
@dosubot

dosubot Bot commented Jan 13, 2026

Copy link
Copy Markdown

Related Documentation

Checked 2 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov

codecov Bot commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.53%. Comparing base (aa2e232) to head (836eeff).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/cmd/grpc.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #5272      +/-   ##
==========================================
- Coverage   60.53%   60.53%   -0.01%     
==========================================
  Files         138      138              
  Lines       13531    13540       +9     
==========================================
+ Hits         8191     8196       +5     
- Misses       4651     4653       +2     
- Partials      689      691       +2     
Flag Coverage Δ
integrationtests 34.62% <63.63%> (+0.01%) ⬆️
unittests 51.80% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@markphelps
markphelps enabled auto-merge (squash) January 31, 2026 13:14
Signed-off-by: Mark Phelps <[email protected]>
@markphelps
markphelps merged commit 32fa455 into v2 Jan 31, 2026
52 of 55 checks passed
@markphelps
markphelps deleted the rd/v2/grpc-prometheus branch January 31, 2026 19:35
erka added a commit that referenced this pull request Feb 4, 2026
…ders/prometheus (#5272)

go-grpc-prometheus is depreacted and archived

Signed-off-by: Roman Dmytrenko <[email protected]>
Co-authored-by: Mark Phelps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants