feat(authn): add fallback name and email for GitHub auth#5154
Merged
Conversation
When a GitHub user does not have a public name or email configured, the Github API returns null. This change provides sensible fallbacks: - Name: Falls back to GitHub login - Email: Falls back to GitHub-provided format <id>+<login>@users.noreply.github.com Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:M
|
Related Documentation Checked 4 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5154 +/- ##
==========================================
+ Coverage 60.50% 60.56% +0.05%
==========================================
Files 138 138
Lines 13495 13499 +4
==========================================
+ Hits 8165 8175 +10
+ Misses 4641 4636 -5
+ Partials 689 688 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a GitHub user does not have a public name or email configured,
the Github API returns null. This change provides sensible fallbacks:
related #5152