fix: enable submit button based on form state in NamespaceForm#4991
Conversation
|
👋 Hi @Yashh56! Thanks for your contribution to this project. It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license. How to fix this: # For future commits, use the -s flag
git commit -s -m "Your commit message"
# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-leaseThe 📋 View the failing DCO check for more details For more information about the DCO, visit: https://developercertificate.org/ |
2a5f420 to
ffedb21
Compare
markphelps
left a comment
There was a problem hiding this comment.
lgtm! one nitpick : would you mind removing emojis from the comments?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #4991 +/- ##
==========================================
+ Coverage 59.84% 60.31% +0.47%
==========================================
Files 136 136
Lines 13394 13394
==========================================
+ Hits 8015 8079 +64
+ Misses 4700 4631 -69
- Partials 679 684 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a28a2cb to
1a7b599
Compare
|
Hey @erka, Thanks For Reviewing the PR, I fixed these issue Please Review it once more. |
|
@Yashh56 could you sign your commits? Please follow these instructions |
Signed-off-by: Yash <[email protected]>
Signed-off-by: Yash <[email protected]>
1a7b599 to
61727d5
Compare
Fix: #2546
This PR improves the responsiveness and reliability of the NamespaceForm by making validation and button states update instantly.
Key Changes:
Enabled real-time validation on change, blur, and mount.
Used setFieldValue to instantly sync field updates and trigger validation.
Added local isButtonEnabled state to update the submit button instantly.
Simplified button logic and cleaned up redundant code for better readability.
Demo:
Flipt._.default.default.-.Brave.2025-11-04.14-38-31.mp4