Skip to content

fix(storage): sync git remote URLs with Flipt config#4975

Merged
markphelps merged 1 commit into
v2from
rd/v2/git-remote-sync
Nov 1, 2025
Merged

fix(storage): sync git remote URLs with Flipt config#4975
markphelps merged 1 commit into
v2from
rd/v2/git-remote-sync

Conversation

@erka

@erka erka commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

When reopening an existing git repository, check if the remote URL
in Flipt configuration differs from the local git config and
synchronize if needed. This handles cases where users update their
repository URL in Flipt configuration.

Also upgrades go-git and related dependencies to latest versions.

@erka
erka requested a review from a team as a code owner October 31, 2025 11:26
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 31, 2025
@dosubot

dosubot Bot commented Oct 31, 2025

Copy link
Copy Markdown

Documentation Updates

1 document(s) were updated by changes in this PR:

flipt

How did I do? Any feedback?  Join Discord

@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.31%. Comparing base (1c942c2) to head (988f86d).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/storage/git/repository.go 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4975      +/-   ##
==========================================
+ Coverage   60.28%   60.31%   +0.03%     
==========================================
  Files         136      136              
  Lines       13380    13394      +14     
==========================================
+ Hits         8066     8079      +13     
+ Misses       4632     4631       -1     
- Partials      682      684       +2     
Flag Coverage Δ
integrationtests 34.87% <0.00%> (-0.04%) ⬇️
unittests 51.35% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

When reopening an existing git repository, check if the remote URL
in Flipt configuration differs from the local git config and
synchronize if needed. This handles cases where users update their
repository URL in Flipt configuration.

Also upgrades go-git and related dependencies to latest versions.

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka
erka force-pushed the rd/v2/git-remote-sync branch from 04a6f22 to 988f86d Compare October 31, 2025 11:40

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markphelps
markphelps merged commit dfd9704 into v2 Nov 1, 2025
29 checks passed
@markphelps
markphelps deleted the rd/v2/git-remote-sync branch November 1, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants