Skip to content

fix: apply tracing stats handler to both gRPC server and in-process channel#4971

Merged
erka merged 1 commit into
v2from
rd/v2/otel-grpc
Oct 30, 2025
Merged

fix: apply tracing stats handler to both gRPC server and in-process channel#4971
erka merged 1 commit into
v2from
rd/v2/otel-grpc

Conversation

@erka

@erka erka commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

The OpenTelemetry stats handler was only being applied to the in-process
channel, not the main gRPC server. This caused incomplete tracing coverage.

related to #4895

…hannel

The OpenTelemetry stats handler was only being applied to the in-process
channel, not the main gRPC server. This caused incomplete tracing coverage.

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka
erka requested a review from a team as a code owner October 30, 2025 12:14
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 30, 2025
@dosubot

dosubot Bot commented Oct 30, 2025

Copy link
Copy Markdown

Documentation Updates

Checked 4 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@erka erka added the v2 Flipt v2 label Oct 30, 2025
@codecov

codecov Bot commented Oct 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.26%. Comparing base (0d67a97) to head (4740e6b).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/cmd/grpc.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4971      +/-   ##
==========================================
- Coverage   60.27%   60.26%   -0.01%     
==========================================
  Files         136      136              
  Lines       13373    13375       +2     
==========================================
  Hits         8061     8061              
- Misses       4630     4632       +2     
  Partials      682      682              
Flag Coverage Δ
integrationtests 34.92% <0.00%> (-0.01%) ⬇️
unittests 51.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka
erka merged commit 351a794 into v2 Oct 30, 2025
30 of 32 checks passed
@erka
erka deleted the rd/v2/otel-grpc branch October 30, 2025 12:35
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants