fix(config): use snake_case for fetch policy in json schema#4957
Merged
Conversation
The existing Test_JSONSchema only validates against the default config, which has empty remote="" so fetch_policy is never included in the output. This meant the schema bug (fetchPolicy vs fetch_policy) went undetected. Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:XS
|
Documentation Updates Checked 4 published document(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #4957 +/- ##
=======================================
Coverage 60.29% 60.29%
=======================================
Files 136 136
Lines 13372 13372
=======================================
Hits 8062 8062
Misses 4629 4629
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Test_JSONSchema only validates against the default config,
which has empty remote="" so fetch_policy is never included in the output.
This meant the schema bug (fetchPolicy vs fetch_policy) went undetected.