fix(config): set schema default Redis mode to "single" instead of empty string#4926
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 flipt-io/flipt#4926 +/- ##
==========================================
+ Coverage 58.97% 59.01% +0.04%
==========================================
Files 135 135
Lines 16874 16874
==========================================
+ Hits 9952 9959 +7
+ Misses 6240 6234 -6
+ Partials 682 681 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51f30ab to
53d9021
Compare
…ty string The Redis mode configuration now defaults to "single" instead of an empty string in schema, which is more explicit and aligns with expected behavior. The empty string option has been removed from the schema. Signed-off-by: Roman Dmytrenko <[email protected]>
53d9021 to
aabf144
Compare
dosubot
Bot
added
the
size:S
|
Documentation Updates Checked 4 published document(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Redis mode configuration by changing its default value from an empty string to "single" in the schema definition. This change makes the default more explicit and aligns with expected behavior.
Key Changes:
- Updated Redis mode default from empty string to "single" in both CUE and JSON schemas
- Removed empty string as a valid enum option for Redis mode
- Updated test configuration to explicitly set Redis mode to "single"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/schema_test.go | Added explicit Redis mode assignment and fixed bare return statement |
| config/flipt.schema.json | Updated Redis mode default to "single", removed empty string enum option, and fixed duration defaults |
| config/flipt.schema.cue | Changed Redis mode default from empty string to "single" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
thank you! |
The Redis mode configuration now defaults to "single" instead of an empty
string in schema, which is more explicit and aligns with expected behavior. The empty
string option has been removed from the schema.
related flipt-io/docs#375