fix(ui): prevent Enter key from submitting form in Tags component#4896
Conversation
Modified the Tags input component to always prevent the default Enter key behavior (form submission), regardless of whether the input has a value. This fixes the issue where pressing Enter in the Values textbox for "IS ONE OF" or "IS NOT ONE OF" constraints would save the entire form instead of just adding a tag. The Enter key now: - Always prevents form submission - Adds a tag only when the input field has a value - Does nothing when the input is empty Fixes #4894 Signed-off-by: Mark Phelps <[email protected]>
dosubot
Bot
added
the
size:XS
|
Related Documentation Checked 4 published document(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a UX issue where pressing Enter in the Tags component's Values textbox would submit the entire constraint form instead of just adding the tag value.
- Restructured the
inputKeyDownfunction to always prevent Enter key's default form submission behavior - Maintains existing functionality where Enter adds a tag only when the input has a value
- Improves user experience by preventing accidental form submissions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #4896 +/- ##
===========================================
+ Coverage 33.86% 59.01% +25.15%
===========================================
Files 127 135 +8
Lines 16246 16874 +628
===========================================
+ Hits 5502 9959 +4457
+ Misses 10179 6234 -3945
- Partials 565 681 +116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Documentation Updates Checked 4 published document(s). No updates required. How did I do? Any feedback? |
Summary
Fixes the issue where pressing Enter in the Values textbox for "IS ONE OF" or "IS NOT ONE OF" constraints would save the entire constraint form instead of just adding the value as a tag.
Changes
ui/src/components/forms/Tags.tsx: Restructured theinputKeyDownfunction to always prevent the default Enter key behavior (form submission), regardless of whether the input has a value.The Enter key now:
Backward Compatibility
This change improves UX without breaking existing functionality. The Enter key will no longer save the constraint form when pressed in the Values input, which was the undesirable behavior reported in the issue.
Fixes #4894