Skip to content

fix(evaluation): add segments to the boolean evaluation response#4766

Merged
erka merged 1 commit into
v2from
rd/v2/bool-segments
Sep 26, 2025
Merged

fix(evaluation): add segments to the boolean evaluation response#4766
erka merged 1 commit into
v2from
rd/v2/bool-segments

Conversation

@erka

@erka erka commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

supports #4759

@github-actions

github-actions Bot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 26, 2025, 11:58 AM

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.67%. Comparing base (6cfab3b) to head (bbafdfc).
⚠️ Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
internal/server/evaluation/evaluation.go 75.00% 1 Missing ⚠️
internal/server/evaluation/ofrep_bridge.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4766      +/-   ##
==========================================
+ Coverage   62.62%   62.67%   +0.04%     
==========================================
  Files         132      132              
  Lines       15531    15535       +4     
==========================================
+ Hits         9727     9736       +9     
+ Misses       5118     5114       -4     
+ Partials      686      685       -1     
Flag Coverage Δ
integrationtests 36.34% <60.00%> (+0.18%) ⬆️
unittests 52.81% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka
erka force-pushed the rd/v2/bool-segments branch from 3fcba18 to bbafdfc Compare September 25, 2025 21:05
@erka erka added the v2 Flipt v2 label Sep 25, 2025
@erka
erka marked this pull request as ready for review September 26, 2025 11:58
@erka
erka requested a review from a team as a code owner September 26, 2025 11:58
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2025
@dosubot

dosubot Bot commented Sep 26, 2025

Copy link
Copy Markdown

Related Documentation

Checked 3 published document(s). No updates required.

You have 3 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@erka
erka merged commit cfe5926 into v2 Sep 26, 2025
59 of 63 checks passed
@erka
erka deleted the rd/v2/bool-segments branch September 26, 2025 19:49
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Sep 26, 2025
@dosubot

dosubot Bot commented Sep 26, 2025

Copy link
Copy Markdown

Documentation Updates

Checked 3 published document(s). No updates required.

You have 3 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

ptejasvini pushed a commit to ptejasvini/flipt that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants