Skip to content

fix(evaluation): add segments to the boolean evaluation response#4765

Merged
erka merged 1 commit into
mainfrom
rd/v1/bool-segments
Sep 26, 2025
Merged

fix(evaluation): add segments to the boolean evaluation response#4765
erka merged 1 commit into
mainfrom
rd/v1/bool-segments

Conversation

@erka

@erka erka commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

supports #4759

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.87%. Comparing base (268f41b) to head (a22435f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4765   +/-   ##
=======================================
  Coverage   63.87%   63.87%           
=======================================
  Files         172      172           
  Lines       17659    17662    +3     
=======================================
+ Hits        11279    11282    +3     
  Misses       5705     5705           
  Partials      675      675           
Flag Coverage Δ
unittests 63.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka added the v1 Flipt v1 label Sep 25, 2025
@erka
erka marked this pull request as ready for review September 26, 2025 11:46
@erka
erka requested a review from a team as a code owner September 26, 2025 11:46
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2025
@dosubot

dosubot Bot commented Sep 26, 2025

Copy link
Copy Markdown

Related Documentation

Checked 3 published document(s). No updates required.

You have 3 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you!

@erka
erka merged commit 3a77d15 into main Sep 26, 2025
42 checks passed
@erka
erka deleted the rd/v1/bool-segments branch September 26, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v1 Flipt v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants