fix: replace panic with proper error handling in EmailMatchingUnaryInterceptor#4744
Merged
Merged
Conversation
…terceptor When using OIDC authentication with email_matches regex patterns and in-memory session storage, pod restarts caused the application to panic with "authentication not found in context, middleware installed incorrectly". Replace the panic with proper error handling that returns errUnauthenticated, following the same pattern used by other middleware functions in the same file. - Replace panic with logger.Error() and return errUnauthenticated - Update existing test to expect error instead of panic - Maintain consistent logging level with other authentication scenarios Fixes #4743 Signed-off-by: markphelps <[email protected]>
dosubot
Bot
added
the
size:S
|
Related Documentation Checked 3 published document(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #4744 +/- ##
===========================================
+ Coverage 36.92% 62.48% +25.56%
===========================================
Files 124 132 +8
Lines 14931 15561 +630
===========================================
+ Hits 5513 9724 +4211
+ Misses 8861 5155 -3706
- Partials 557 682 +125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Documentation Updates Checked 3 published document(s). No updates required. You have 3 draft document(s). Publish docs to keep them always up-to-date How did I do? Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a panic in the
EmailMatchingUnaryInterceptormiddleware that occurs when authentication is not found in context (e.g., after pod restarts with in-memory session storage).email_matchespatterns and in-memory sessions, pod restarts cause sessions to be lost, leading toGetAuthenticationFrom(ctx)returningnilerrUnauthenticatederror like other middleware functions in the same fileChanges
internal/server/authn/middleware/grpc/middleware.go: Replace panic with proper error handling following established patternsinternal/server/authn/middleware/grpc/middleware_test.go: Update existing test to expect error instead of panicTest Plan
TestEmailMatchingUnaryInterceptorWithNoAuthto verify error handlingBackward Compatibility
Maintained - API behavior unchanged, clients still receive 401 Unauthorized responses. Only difference is proper error handling instead of application crash.
Fixes #4743