Skip to content

fix: get environment key from streaming subscribe request#4733

Merged
kodiakhq[bot] merged 1 commit into
v2from
fix-streaming-env-support
Sep 12, 2025
Merged

fix: get environment key from streaming subscribe request#4733
kodiakhq[bot] merged 1 commit into
v2from
fix-streaming-env-support

Conversation

@markphelps

Copy link
Copy Markdown
Collaborator

We werent getting the environment key from the request for v2 streaming 🤦🏻

Now its required

Closes #4732

@markphelps
markphelps requested a review from a team as a code owner September 12, 2025 15:16
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 12, 2025
@markphelps
markphelps requested a review from erka September 12, 2025 15:17
@dosubot

dosubot Bot commented Sep 12, 2025

Copy link
Copy Markdown

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.48%. Comparing base (465e630) to head (be8f171).
⚠️ Report is 5 commits behind head on v2.

Files with missing lines Patch % Lines
internal/server/evaluation/client/server.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4733      +/-   ##
==========================================
- Coverage   62.49%   62.48%   -0.01%     
==========================================
  Files         132      132              
  Lines       15554    15559       +5     
==========================================
+ Hits         9720     9722       +2     
- Misses       5153     5155       +2     
- Partials      681      682       +1     
Flag Coverage Δ
integrationtests 36.92% <72.72%> (+<0.01%) ⬆️
unittests 52.61% <72.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@erka erka added the v2 Flipt v2 label Sep 12, 2025
@erka erka added the automerge Used by Kodiak bot to automerge PRs label Sep 12, 2025
@kodiakhq
kodiakhq Bot merged commit 4d02b95 into v2 Sep 12, 2025
32 checks passed
@kodiakhq
kodiakhq Bot deleted the fix-streaming-env-support branch September 12, 2025 15:33
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Sep 12, 2025
@dosubot

dosubot Bot commented Sep 12, 2025

Copy link
Copy Markdown

Documentation Updates

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants