fix: accept http/2 connections#4715
Merged
Merged
Conversation
markphelps
reviewed
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #4715 +/- ##
=======================================
Coverage 62.48% 62.49%
=======================================
Files 132 132
Lines 15556 15554 -2
=======================================
Hits 9720 9720
+ Misses 5155 5153 -2
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@causton81 could you please sign the commit off? |
Contributor
Author
|
Hello, @erka! I see a |
Contributor
|
@causton81 DCO action refuses to accept your sign off. Here is the error |
Signed-off-by: Chris AUSTON <[email protected]>
Contributor
Author
|
Ok, I amended with the signature from |
Contributor
|
@causton81 thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I've been trying to get client streaming working with the Java client. The only way I can get it to work is with this patch and one I'll submit on the flipt-client-sdks project.
Sorry for the dirty patch but I'm not entirely sure that I didn't miss something upstream that would work without patches?
flipt-io/flipt-client-sdks#1314