Skip to content

fix: accept http/2 connections#4715

Merged
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
causton81:v2
Sep 10, 2025
Merged

fix: accept http/2 connections#4715
kodiakhq[bot] merged 2 commits into
flipt-io:v2from
causton81:v2

Conversation

@causton81

@causton81 causton81 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Hello! I've been trying to get client streaming working with the Java client. The only way I can get it to work is with this patch and one I'll submit on the flipt-client-sdks project.
Sorry for the dirty patch but I'm not entirely sure that I didn't miss something upstream that would work without patches?

flipt-io/flipt-client-sdks#1314

@causton81
causton81 requested a review from a team as a code owner September 9, 2025 22:47
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 9, 2025
@dosubot

dosubot Bot commented Sep 9, 2025

Copy link
Copy Markdown

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Comment thread internal/cmd/http.go Outdated
@codecov

codecov Bot commented Sep 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.49%. Comparing base (81ecf48) to head (b9f4d47).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #4715   +/-   ##
=======================================
  Coverage   62.48%   62.49%           
=======================================
  Files         132      132           
  Lines       15556    15554    -2     
=======================================
  Hits         9720     9720           
+ Misses       5155     5153    -2     
  Partials      681      681           
Flag Coverage Δ
integrationtests 36.92% <ø> (+<0.01%) ⬆️
unittests 52.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 10, 2025
@erka

erka commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@causton81 could you please sign the commit off?

@causton81

Copy link
Copy Markdown
Contributor Author

Hello, @erka! I see a Signed-off-by: Chris Auston <[email protected]> in my rebased commit. Do you need something else?

@erka

erka commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@causton81 DCO action refuses to accept your sign off. Here is the error

Commit sha: [f7261ee](https://github.com/flipt-io/flipt/pull/4715/commits/f7261ee6b2f3bd28f9272e91978d21186934f3dc),
 Author: Chris AUSTON, Committer: Chris AUSTON; Expected "Chris AUSTON [email protected]", but got "Chris Auston [email protected]".

@causton81

Copy link
Copy Markdown
Contributor Author

Ok, I amended with the signature from git commit -s and pushed back up.

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! ty @causton81

@erka erka added automerge Used by Kodiak bot to automerge PRs v2 Flipt v2 labels Sep 10, 2025
@erka erka changed the title fix(streaming): accept http/2 connections fix: accept http/2 connections Sep 10, 2025
@kodiakhq
kodiakhq Bot merged commit eb1ee16 into flipt-io:v2 Sep 10, 2025
37 of 40 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Sep 10, 2025
@dosubot

dosubot Bot commented Sep 10, 2025

Copy link
Copy Markdown

Documentation Updates

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@erka

erka commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@causton81 thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:XS This PR changes 0-9 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants