Skip to content

docs: add rohitnarayan as a contributor for code#4684

Closed
allcontributors[bot] wants to merge 383 commits into
mainfrom
all-contributors/add-rohitnarayan
Closed

docs: add rohitnarayan as a contributor for code#4684
allcontributors[bot] wants to merge 383 commits into
mainfrom
all-contributors/add-rohitnarayan

Conversation

@allcontributors

Copy link
Copy Markdown
Contributor

Adds @rohitnarayan as a contributor for code.

This was requested by erka in this comment

[skip ci]

markphelps and others added 30 commits May 21, 2025 15:24
* feat(wip): support pr workflows

Signed-off-by: Mark Phelps <[email protected]>

* chore: impl branch at server; noop publisher

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix abililty to create and track remote branches

Signed-off-by: Mark Phelps <[email protected]>

* chore: reset config

Signed-off-by: Mark Phelps <[email protected]>

* chore: config again

Signed-off-by: Mark Phelps <[email protected]>

* chore: set base for branched envs

Signed-off-by: Mark Phelps <[email protected]>

* chore: explicit return

Signed-off-by: Mark Phelps <[email protected]>

* chore: regen mock

Signed-off-by: Mark Phelps <[email protected]>

* chore: add list branches and add tests

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix build

Signed-off-by: Mark Phelps <[email protected]>

* chore: mockery

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix linter errors

Signed-off-by: Mark Phelps <[email protected]>

* chore: nolint

Signed-off-by: Mark Phelps <[email protected]>

* chore: revert config

Signed-off-by: Mark Phelps <[email protected]>

* chore: fmt proto

Signed-off-by: Mark Phelps <[email protected]>

* chore: try to upgrade dagger version to fix build

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix proto bootstrap

Signed-off-by: Mark Phelps <[email protected]>

* chore: set protoc-gen-go-grpc to latest

Signed-off-by: Mark Phelps <[email protected]>

* chore: mod tidy

Signed-off-by: Mark Phelps <[email protected]>

* V2 branch 2 (#4232)

* feat: branch picker start

Signed-off-by: Mark Phelps <[email protected]>

* feat: make branch switcher work

Signed-off-by: Mark Phelps <[email protected]>

* chore: more branch work

Signed-off-by: Mark Phelps <[email protected]>

* feat: switch to newly created branch after branching

Signed-off-by: Mark Phelps <[email protected]>

* chore: styles

Signed-off-by: Mark Phelps <[email protected]>

* chore: regen mocks

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix test

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
- fix the issue when new not-saved variant isn't available in rules
  components
- move remove default rule into dropdown to unify the layout
- fix styles here and there with new colors
- update rollouts
* chore: cleanup config for consistency

Signed-off-by: Mark Phelps <[email protected]>

* chore: set data poll interval if configured

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* fix: commit listing for changes was backward

Signed-off-by: Mark Phelps <[email protected]>

* fix: fix propose changes too

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* feat: add ability to delete branch env

Signed-off-by: Mark Phelps <[email protected]>

* fix: commit listing for changes was backward (#4264)

* fix: commit listing for changes was backward

Signed-off-by: Mark Phelps <[email protected]>

* fix: fix propose changes too

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* feat: add ability to delete branch env

Signed-off-by: Mark Phelps <[email protected]>

* feat: start merging create proposals and branches into dropdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: consolidate branched env stuff into dropdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: change action language

Signed-off-by: Mark Phelps <[email protected]>

* chore: use our input for delete modal

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix delete branch input

Signed-off-by: Mark Phelps <[email protected]>

* chore: add branch delete IT

Signed-off-by: Mark Phelps <[email protected]>

* chore: rename api parts

Signed-off-by: Mark Phelps <[email protected]>

* chore: branch from local

Signed-off-by: Mark Phelps <[email protected]>

* chore: default branch

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
Node.js 18 is reached End-of-Life on 30 April 2025. Switching to new LTS
* chore: upgrade rego to v1

Signed-off-by: Mark Phelps <[email protected]>

* chore: add request types for env

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
#4267)

* chore: upgrade rego to v1

Signed-off-by: Mark Phelps <[email protected]>

* chore: use rego authz helper; bindings for consistency in policy eval; capture panic stacktraces

Signed-off-by: Mark Phelps <[email protected]>

* chore: improve locking in update functions

Signed-off-by: Mark Phelps <[email protected]>

* chore: guard against zero value prepared queries

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* fix: disallow branches with existing env name

Signed-off-by: Mark Phelps <[email protected]>

* chore: strings equal fold

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
*  v2 use one style for dialogs
* remove deadcode; use text-brand; rm quotes around delete branch name

Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Co-authored-by: Mark Phelps <[email protected]>
There is no sidebar rail in the moment so having extra margin on the
left makes things a bit asymmetrical
* fix: push to remote on branch create

Signed-off-by: Mark Phelps <[email protected]>

* chore: clear textbox on branch close

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* chore: update inapp links for v2 docs

Signed-off-by: Mark Phelps <[email protected]>

* chore: finish links

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix spec

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix spec

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* feat: work on gitlab support

Signed-off-by: Mark Phelps <[email protected]>

* chore: add gitlab url test

Signed-off-by: Mark Phelps <[email protected]>

* chore: add gitlab

Signed-off-by: Mark Phelps <[email protected]>

* chore: pass in gitlab client opts

Signed-off-by: Mark Phelps <[email protected]>

* feat: convert between correct auth for git and api

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix lint issue

Signed-off-by: Mark Phelps <[email protected]>

* fix: put scm on env in api; fix open pr tracking in ui

Signed-off-by: Mark Phelps <[email protected]>

* chore: add gitlab tests

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix tests

Signed-off-by: Mark Phelps <[email protected]>

* chore: test feedback

Signed-off-by: Mark Phelps <[email protected]>

* chore: pr feedback

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix typo

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
* feat: initial licensing enforcment impl

Signed-off-by: Mark Phelps <[email protected]>

* chore: wire in keygen variables

Signed-off-by: Mark Phelps <[email protected]>

* chore: mod tidy

Signed-off-by: Mark Phelps <[email protected]>

* chore: uncomment dev mode

Signed-off-by: Mark Phelps <[email protected]>

* chore: dont cancel shutdown context for now; rm keygen debug statements

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix lints

Signed-off-by: Mark Phelps <[email protected]>

* chore: simplify return

Signed-off-by: Mark Phelps <[email protected]>

* chore: cancel shutdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: put back footer

Signed-off-by: Mark Phelps <[email protected]>

* fix: hang on shutdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: rm double warning log

Signed-off-by: Mark Phelps <[email protected]>

* chore: rename enterprise

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
markphelps and others added 20 commits September 3, 2025 09:48
feat: support Git repository initialization for existing features files
…4678)

Remove omitempty tag from Distribution.Rollout and ThresholdRule.Percentage
fields to fix CUE validation errors when these fields have zero values.

- Fixed Distribution.Rollout field to always serialize, even when 0
- Fixed ThresholdRule.Percentage field to always serialize, even when 0
- Added comprehensive tests for YAML and JSON serialization with zero values
- Added CUE validation test case with zero values

Fixes #4677

Signed-off-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Currently, Flipt has inconsistent support for .yml vs .yaml file
extensions for features files. While configuration and parsing layers
support both extensions, namespace discovery and file operations
hardcode features.yaml, creating inconsistencies where .yml files
may be committed to Git but not properly discovered as namespaces.

Changes:
- Add helper functions TryOpenFeaturesFile and FindFeaturesFilename
- Update namespace discovery to check both .yaml and .yml extensions
- Update flags and segments operations to preserve existing extensions
- New files default to .yaml extension for consistency
- Update error messages to reference both supported extensions
- Add comprehensive test coverage for yml extension support

Benefits:
- Both extensions work uniformly across all Flipt operations
- User flexibility to choose preferred YAML extension
- Git integration works with both extensions
- Backward compatibility maintained
- Extension preservation for existing files

Fixes #4676

Signed-off-by: Claude <[email protected]>
Update documentEncoder to store and use the actual filename
(features.yaml or features.yml) when calling validator.Validate(),
providing more accurate error messages to users.

- Add filename field to documentEncoder struct
- Update newDocumentEncoder to accept filename parameter
- Pass actual discovered filename to validation calls
- Update all newDocumentEncoder calls in flags.go and segments.go

Signed-off-by: Claude <[email protected]>
Signed-off-by: Claude <[email protected]>
Signed-off-by: Claude <[email protected]>
- Added workflow that validates renovate.json5 using suzuki-shunsuke/[email protected]
- Workflow only runs when .github/renovate.json5 is modified
- Supports push, pull_request, and manual triggers via workflow_dispatch

Co-authored-by: markphelps <[email protected]>
Signed-off-by: Claude <[email protected]>
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Claude <[email protected]>
…-a260-afca22576888

chore: Group OpenTelemetry dependencies in Renovate configuration and add validation workflow
* v2:
  chore: dont put on in quotes
  Potential fix for code scanning alert no. 78: Workflow does not contain permissions
  chore: try to set version for renovate validator
  feat: add Renovate config validation workflow
  Group OpenTelemetry dependencies in Renovate config
  Initial plan
…support

feat: support .yml extension for features files in addition to .yaml
Signed-off-by: Claude <[email protected]>
chore: prep for v2.1.0 release
@allcontributors
allcontributors Bot requested a review from a team as a code owner September 4, 2025 21:11
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 4, 2025
@dosubot

dosubot Bot commented Sep 4, 2025

Copy link
Copy Markdown

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@erka
erka changed the base branch from v2 to main September 4, 2025 21:13
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 4, 2025
@erka erka closed this Sep 4, 2025
@rohitnarayan

Copy link
Copy Markdown

@erka have I been added as a contributor ?

@erka

erka commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

@rohitnarayan I have recreated the PR for it. It will be merged in main next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants