fix(storage): add namespace ETag support across multiple files#4500
Merged
Conversation
dosubot
Bot
added
the
size:S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4500 +/- ##
==========================================
+ Coverage 63.73% 63.75% +0.01%
==========================================
Files 171 171
Lines 17622 17631 +9
==========================================
+ Hits 11231 11240 +9
Misses 5720 5720
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
rd/v1/ns-etag-multi-files
branch
from
August 1, 2025 12:48
431da34 to
68c3e0e
Compare
markphelps
approved these changes
Aug 1, 2025
markphelps
left a comment
markphelps
left a comment
Collaborator
There was a problem hiding this comment.
one minor question, otherwise lgtm!
| hash.Write([]byte(etag)) | ||
| sum := hash.Sum(nil) | ||
| etag = hex.EncodeToString(sum) | ||
| etag = etag[:12] // truncate to 12 characters for consistency |
Collaborator
There was a problem hiding this comment.
just curious why 12 and not something larger like 32?
Contributor
Author
There was a problem hiding this comment.
@markphelps Docker and Git typically display a shortened version of the hash. Docker, for example, uses 12 characters. We don't use it for security reason so I decided to have a short version of it
markphelps
added a commit
that referenced
this pull request
Aug 1, 2025
* main: chore: bump etag length for multi-docs to 32 (#4501) fix(storage): add namespace ETag support across multiple files (#4500) fix(ui): variant with no name is not shown in the rules (#4499) Update github.com/bufbuild/buf in _tools to v1.55.1 (#4460) chore: ensure v1 release workflows only run on a v1 release (#4458) chore: remove the sandbox section from readme (#4447) chore: Release/1.59 (#4446)
erka
added a commit
that referenced
this pull request
Jun 16, 2026
port #4500, #4501 to v2 Signed-off-by: Roman Dmytrenko <[email protected]>
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 19, 2026
port #4500, #4501 to v2 Signed-off-by: Roman Dmytrenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/960634591000014878/1400563697092657203