Skip to content

fix: Push on branch#4309

Merged
markphelps merged 2 commits into
v2from
push-on-branch
Jun 9, 2025
Merged

fix: Push on branch#4309
markphelps merged 2 commits into
v2from
push-on-branch

Conversation

@markphelps

@markphelps markphelps commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Fixes: #4265

  • push remote branch if remote configured on create
  • clear branch name input on branch modal close

2025-06-09 14 58 04

@markphelps
markphelps requested a review from a team as a code owner June 9, 2025 18:59
@markphelps
markphelps requested a review from erka June 9, 2025 18:59
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 9, 2025
@codecov

codecov Bot commented Jun 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 37.50000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 50.50%. Comparing base (5588468) to head (b3b5916).
Report is 13 commits behind head on v2.

Files with missing lines Patch % Lines
internal/storage/git/repository.go 24.00% 17 Missing and 2 partials ⚠️
internal/storage/git/metrics.go 54.54% 9 Missing and 1 partial ⚠️
internal/storage/environments/git/store.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4309      +/-   ##
==========================================
- Coverage   50.65%   50.50%   -0.15%     
==========================================
  Files         122      122              
  Lines       13200    13247      +47     
==========================================
+ Hits         6686     6691       +5     
- Misses       5950     5988      +38     
- Partials      564      568       +4     
Flag Coverage Δ
unittests 50.50% <37.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@markphelps
markphelps merged commit ca3a578 into v2 Jun 9, 2025
@markphelps
markphelps deleted the push-on-branch branch June 9, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants