Skip to content

fix: v2 patch broken templates for propose changes#4274

Merged
erka merged 1 commit into
v2from
rd/v2/fix-propose-templates
Jun 1, 2025
Merged

fix: v2 patch broken templates for propose changes#4274
erka merged 1 commit into
v2from
rd/v2/fix-propose-templates

Conversation

@erka

@erka erka commented Jun 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.63%. Comparing base (5588468) to head (52272b0).
Report is 9 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4274      +/-   ##
==========================================
- Coverage   50.65%   50.63%   -0.02%     
==========================================
  Files         122      122              
  Lines       13200    13213      +13     
==========================================
+ Hits         6686     6691       +5     
- Misses       5950     5957       +7     
- Partials      564      565       +1     
Flag Coverage Δ
unittests 50.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka
erka force-pushed the rd/v2/fix-propose-templates branch from 5ffb6f8 to 52272b0 Compare June 1, 2025 20:25
@erka erka changed the title fix: v2 fix templates for propose changes fix: v2 patch broken templates for propose changes Jun 1, 2025
@erka erka added the v2 Flipt v2 label Jun 1, 2025
@erka
erka marked this pull request as ready for review June 1, 2025 20:44
@erka
erka requested a review from a team as a code owner June 1, 2025 20:44
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 1, 2025

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@erka
erka merged commit cecdb31 into v2 Jun 1, 2025
@erka
erka deleted the rd/v2/fix-propose-templates branch June 1, 2025 21:36
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants