Skip to content

fix: disallow branches with existing env name#4272

Merged
markphelps merged 2 commits into
v2from
v2-disallow-duplicate-branches
May 31, 2025
Merged

fix: disallow branches with existing env name#4272
markphelps merged 2 commits into
v2from
v2-disallow-duplicate-branches

Conversation

@markphelps

@markphelps markphelps commented May 30, 2025

Copy link
Copy Markdown
Collaborator

disallow creating branches with existing environment name

@markphelps
markphelps requested a review from a team as a code owner May 30, 2025 19:59
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 30, 2025
@markphelps
markphelps requested a review from erka May 30, 2025 19:59
@codecov

codecov Bot commented May 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.63%. Comparing base (5588468) to head (251e4b4).
Report is 8 commits behind head on v2.

Files with missing lines Patch % Lines
internal/server/environments/storage.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v2    #4272      +/-   ##
==========================================
- Coverage   50.65%   50.63%   -0.02%     
==========================================
  Files         122      122              
  Lines       13200    13213      +13     
==========================================
+ Hits         6686     6691       +5     
- Misses       5950     5957       +7     
- Partials      564      565       +1
Flag Coverage Δ
unittests 50.63% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps
chore: strings equal fold
251e4b4 
Signed-off-by: Mark Phelps <[email protected]>
@erka

erka commented May 30, 2025 via email

Copy link
Copy Markdown
Contributor

@markphelps

markphelps commented May 30, 2025

Copy link
Copy Markdown
Collaborator Author

@erka

the API calls this code: https://github.com/flipt-io/flipt/pull/4272/files#diff-d21e568d7b2f1975acb0ab2a0a6b33dcc09a88949591c551229daac7f6bc58f4R179-R184

I will add some tests though

erka
erka approved these changes May 31, 2025
View reviewed changes

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@erka erka added the v2 Flipt v2 label May 31, 2025
@markphelps
markphelps merged commit 2d615dc into v2 May 31, 2025
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 May 31, 2025
@markphelps
markphelps deleted the v2-disallow-duplicate-branches branch May 31, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erka erka erka approved these changes

Assignees

No one assigned

Labels

size:L This PR changes 100-499 lines, ignoring generated files. v2 Flipt v2

Projects

Flipt V2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markphelps @erka