Skip to content

v2: Upgrade OPA#4268

Merged
markphelps merged 2 commits into
v2from
upgrade-rego
May 30, 2025
Merged

v2: Upgrade OPA#4268
markphelps merged 2 commits into
v2from
upgrade-rego

Conversation

@markphelps

@markphelps markphelps commented May 30, 2025

Copy link
Copy Markdown
Collaborator

upgrade OPA rego/storage libraries to v1.x https://github.com/open-policy-agent/opa

From the looks of it we should be backward compatible as we dont import the future.keywords: https://www.openpolicyagent.org/docs/v0-compatibility

see: #4267 as well

Signed-off-by: Mark Phelps <[email protected]>
@markphelps
markphelps requested a review from a team as a code owner May 30, 2025 01:05
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 30, 2025
@markphelps
markphelps requested a review from erka May 30, 2025 01:05
@codecov

codecov Bot commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.65%. Comparing base (5588468) to head (ef24a7e).
Report is 4 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #4268   +/-   ##
=======================================
  Coverage   50.65%   50.65%           
=======================================
  Files         122      122           
  Lines       13200    13200           
=======================================
  Hits         6686     6686           
  Misses       5950     5950           
  Partials      564      564           
Flag Coverage Δ
unittests 50.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka

erka commented May 30, 2025

Copy link
Copy Markdown
Contributor

... ERROR request must implement flipt.Requester {"server": "grpc", "method": "/environments.EnvironmentsService/ListEnvironments"}

I guess we need to address this othewise UI is not working

@markphelps

Copy link
Copy Markdown
Collaborator Author

... ERROR request must implement flipt.Requester {"server": "grpc", "method": "/environments.EnvironmentsService/ListEnvironments"}

I guess we need to address this othewise UI is not working

ah good call. will do that now

@github-actions

github-actions Bot commented May 30, 2025

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 30, 2025, 2:43 PM

@markphelps

Copy link
Copy Markdown
Collaborator Author

Added to rpc/v2/environments/request.go

I kept them all as read actions until we have a better way of handling branched env permissions

@erka erka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

The main challenge was updating the package declaration in my existing policy.rego file to package flipt.authz.v2.
It would be helpful to include this as a migration tip in the v2 documentation for users upgrading from earlier v1 versions.

@erka erka added the v2 Flipt v2 label May 30, 2025
@markphelps

Copy link
Copy Markdown
Collaborator Author

nice!

The main challenge was updating the package declaration in my existing policy.rego file to package flipt.authz.v2. It would be helpful to include this as a migration tip in the v2 documentation for users upgrading from earlier v1 versions.

I'll create a new issue to track notes we should add to migration docs

@markphelps

Copy link
Copy Markdown
Collaborator Author

@markphelps
markphelps merged commit 8a68181 into v2 May 30, 2025
@markphelps
markphelps deleted the upgrade-rego branch May 30, 2025 14:54
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants