Skip to content

fix: commit listing for changes was backward#4264

Merged
markphelps merged 2 commits into
v2from
v2-fix-proposal-changes
May 29, 2025
Merged

fix: commit listing for changes was backward#4264
markphelps merged 2 commits into
v2from
v2-fix-proposal-changes

Conversation

@markphelps

@markphelps markphelps commented May 29, 2025

Copy link
Copy Markdown
Collaborator

i had the environments swapped around which meant the changes between branches were not showing correctly

turns out propose changes was backward too

@markphelps
markphelps requested a review from a team as a code owner May 29, 2025 16:05
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 29, 2025
@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@30f4909). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ernal/enterprise/storage/environments/git/store.go 0.00% 6 Missing ⚠️
internal/server/environments/storage.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #4264   +/-   ##
=====================================
  Coverage      ?   50.91%           
=====================================
  Files         ?      122           
  Lines         ?    13116           
  Branches      ?        0           
=====================================
  Hits          ?     6678           
  Misses        ?     5874           
  Partials      ?      564           
Flag Coverage Δ
unittests 50.91% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mark Phelps <[email protected]>
@markphelps
markphelps merged commit a437e5f into v2 May 29, 2025
@markphelps
markphelps deleted the v2-fix-proposal-changes branch May 29, 2025 16:34
markphelps added a commit that referenced this pull request May 29, 2025
* feat: add ability to delete branch env

Signed-off-by: Mark Phelps <[email protected]>

* fix: commit listing for changes was backward (#4264)

* fix: commit listing for changes was backward

Signed-off-by: Mark Phelps <[email protected]>

* fix: fix propose changes too

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* feat: add ability to delete branch env

Signed-off-by: Mark Phelps <[email protected]>

* feat: start merging create proposals and branches into dropdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: consolidate branched env stuff into dropdown

Signed-off-by: Mark Phelps <[email protected]>

* chore: change action language

Signed-off-by: Mark Phelps <[email protected]>

* chore: use our input for delete modal

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix delete branch input

Signed-off-by: Mark Phelps <[email protected]>

* chore: add branch delete IT

Signed-off-by: Mark Phelps <[email protected]>

* chore: rename api parts

Signed-off-by: Mark Phelps <[email protected]>

* chore: branch from local

Signed-off-by: Mark Phelps <[email protected]>

* chore: default branch

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
@erka erka added the v2 Flipt v2 label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files. v2 Flipt v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants