feat: consolidate branch actions; allow deleting branch#4263
Merged
Conversation
Signed-off-by: Mark Phelps <[email protected]>
dosubot
Bot
added
the
size:XL
Contributor
|
The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #4263 +/- ##
=====================================
Coverage ? 50.65%
=====================================
Files ? 122
Lines ? 13200
Branches ? 0
=====================================
Hits ? 6686
Misses ? 5950
Partials ? 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix: commit listing for changes was backward Signed-off-by: Mark Phelps <[email protected]> * fix: fix propose changes too Signed-off-by: Mark Phelps <[email protected]> --------- Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Contributor
|
We need to adjust input in dark mode as Formik uses own compoment |
Signed-off-by: Mark Phelps <[email protected]>
…into v2-delete-branch * 'v2-delete-branch' of https://github.com/flipt-io/flipt: feat: add ability to delete branch env
dosubot
Bot
added
size:XXL
Signed-off-by: Mark Phelps <[email protected]>
markphelps
changed the title
Signed-off-by: Mark Phelps <[email protected]>
Collaborator
Author
|
@erka how about this? |
Contributor
It looks nice. Formik doesn't validate my input anymore and I can see only error
|
Collaborator
Author
Ah will fix. And should likely add a UI IT as well |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Collaborator
Author
|
@erka fixed and added ITs |
Signed-off-by: Mark Phelps <[email protected]>
Collaborator
Author
|
I also renamed the keys like we talked about |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stagingin this example