fix(ui): v2 improve flag rules controls#4259
Merged
Merged
Conversation
erka
commented
May 28, 2025
erka
commented
Contributor
- fix the issue when new not-saved variant isn't available in rules components
- move remove default rule into dropdown to unify the layout
- fix styles here and there with new colors
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #4259 +/- ##
=====================================
Coverage ? 50.97%
=====================================
Files ? 121
Lines ? 12759
Branches ? 0
=====================================
Hits ? 6504
Misses ? 5728
Partials ? 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- fix the issue when new not-saved variant isn't available in rules components - move remove default rule into dropdown to unify the layout - fix styles here and there with new colors Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
marked this pull request as ready for review
May 28, 2025 17:19
dosubot
Bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.