feat: V2 proposals by markphelps · Pull Request #4237 · flipt-io/flipt

markphelps · 2025-05-22T19:29:02Z

Opening this up now as it's already gotten large.

Will add tests and error handling in another followup PR

Note: The screenshots with the tooltips are not actually transparent, its just due to the timing when i took the screenshot

Theres still bugs and room for improvement like:

fixing draft option
show url to PR
show status of PR using icon/color
error handling to prevent user from trying to create multiple prs on same branch
add tests

github-actions · 2025-05-22T19:29:19Z

The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`❌ failed (10)`	May 28, 2025, 8:41 PM

Signed-off-by: Mark Phelps <[email protected]>

sidebar has Signed-off-by: Roman Dmytrenko <[email protected]>

Signed-off-by: Mark Phelps <[email protected]>

…lipt-io/flipt into v2-env-namespace-branch-picker * 'v2-env-namespace-branch-picker' of https://github.com/flipt-io/flipt: remove double border and use the same spacing between icon and text as sidebar has

Signed-off-by: Mark Phelps <[email protected]>

* v2-env-namespace-branch-picker: chore: rm unused component fix: env/namespace switching remove double border and use the same spacing between icon and text as sidebar has

* v2: feat: redo the env/namespace switcher component to handle branches (#4238) chore: update vite to v6.3.5 and drop react-helmet (#4241) fix(ui): v2 clean the styles and refine some texts on support page (#4240) chore(deps): v2 drop unused packages (#4239)

* v2: refactor(ui): v2 cleanup input styles (#4256)

codecov · 2025-05-27T13:32:06Z

Codecov Report

Attention: Patch coverage is 31.64129% with 404 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@a4214cd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
internal/storage/environments/environments.go	0.00%	146 Missing ⚠️
...ise/storage/environments/git/github/github_mock.go	53.52%	42 Missing and 24 partials ⚠️
...ernal/enterprise/storage/environments/git/store.go	0.00%	60 Missing ⚠️
internal/server/environments/environments_mock.go	0.00%	52 Missing ⚠️
internal/server/environments/server.go	0.00%	31 Missing ⚠️
...terprise/storage/environments/git/github/github.go	75.63%	22 Missing and 7 partials ⚠️
internal/storage/environments/git/store.go	30.00%	14 Missing ⚠️
internal/config/environments.go	69.23%	3 Missing and 1 partial ⚠️
internal/server/environments/storage.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##             v2    #4237   +/-   ##
=====================================
  Coverage      ?   50.91%           
=====================================
  Files         ?      122           
  Lines         ?    13116           
  Branches      ?        0           
=====================================
  Hits          ?     6678           
  Misses        ?     5874           
  Partials      ?      564

Flag	Coverage Δ
unittests	`50.91% <31.64%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mark Phelps <[email protected]>

* v2-config-cleanup: chore: cleanup config for consistency

Signed-off-by: Mark Phelps <[email protected]>

* v2: chore: v2 cleanup config for consistency (#4260) fix(ui): v2 improve flag rules controls (#4259) chore(deps): bump some vulnerable deps (#4258) build: v2 remove unused dependencies in Dockerfile (#4257)

Signed-off-by: Mark Phelps <[email protected]>

markphelps added 3 commits May 23, 2025 11:47

feat: redo the env/namespace switcher component to handle branches

ddcfccd

Signed-off-by: Mark Phelps <[email protected]>

chore: try to fix UI specs

86eeed8

Signed-off-by: Mark Phelps <[email protected]>

chore: add basic create branch spec

b3a1b8e

Signed-off-by: Mark Phelps <[email protected]>

markphelps force-pushed the v2-proposals branch from 532064a to c637087 Compare May 23, 2025 17:11

markphelps and others added 21 commits May 23, 2025 14:03

chore: fix flag/segment specs

24bba5d

Signed-off-by: Mark Phelps <[email protected]>

chore: add padding

a12dc0a

Signed-off-by: Mark Phelps <[email protected]>

feat: get proposal auth wired up

905b521

Signed-off-by: Mark Phelps <[email protected]>

chore(wip): refactor

88547b9

Signed-off-by: Mark Phelps <[email protected]>

chore: fix repo notifications

4d9a4b1

Signed-off-by: Mark Phelps <[email protected]>

chore: rm deadcode

b4bd5d0

Signed-off-by: Mark Phelps <[email protected]>

chore: move subscribing up

ff23271

Signed-off-by: Mark Phelps <[email protected]>

feat: finish proposal functionality

258bc29

Signed-off-by: Mark Phelps <[email protected]>

chore: proto fmt; fix body

a5b02e4

Signed-off-by: Mark Phelps <[email protected]>

chore: pass in body

c838ce5

Signed-off-by: Mark Phelps <[email protected]>

chore: update default template

c082b41

Signed-off-by: Mark Phelps <[email protected]>

chore: make remote/dir optional, improve header

f38dca7

Signed-off-by: Mark Phelps <[email protected]>

chore: fix branch component

3128b21

Signed-off-by: Mark Phelps <[email protected]>

remove double border and use the same spacing between icon and text as

10678c2

sidebar has Signed-off-by: Roman Dmytrenko <[email protected]>

chore: fix styling

ca792c7

Signed-off-by: Mark Phelps <[email protected]>

fix: env/namespace switching

41c423e

Signed-off-by: Mark Phelps <[email protected]>

chore: rm unused component

6bc5da5

Signed-off-by: Mark Phelps <[email protected]>

Merge branch 'v2-env-namespace-branch-picker' into v2-proposals

d31f452

* v2-env-namespace-branch-picker: chore: rm unused component fix: env/namespace switching remove double border and use the same spacing between icon and text as sidebar has

Merge branch 'v2' into v2-proposals

06eab76

* v2: refactor(ui): v2 cleanup input styles (#4256)

markphelps added 3 commits May 27, 2025 15:53

feat: show proposal status

fbe09cd

Signed-off-by: Mark Phelps <[email protected]>

chore: fix ui lint

30f5d59

Signed-off-by: Mark Phelps <[email protected]>

chore: add nolint directive

7cb9036

Signed-off-by: Mark Phelps <[email protected]>

markphelps marked this pull request as ready for review May 27, 2025 19:59

markphelps requested a review from a team as a code owner May 27, 2025 19:59

dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 27, 2025

markphelps added 8 commits May 27, 2025 16:01

chore: regen mocks

f2b33e1

Signed-off-by: Mark Phelps <[email protected]>

chore: cleanup config for consistency

1924f58

Signed-off-by: Mark Phelps <[email protected]>

Merge branch 'v2-config-cleanup' into v2-proposals

6a53405

* v2-config-cleanup: chore: cleanup config for consistency

chore: support github enterprise urls for github scm

30b8e05

Signed-off-by: Mark Phelps <[email protected]>

Merge branch 'v2' into v2-proposals

0995651

* v2: chore: v2 cleanup config for consistency (#4260) fix(ui): v2 improve flag rules controls (#4259) chore(deps): bump some vulnerable deps (#4258) build: v2 remove unused dependencies in Dockerfile (#4257)

chore: add github scm tests

c41457b

Signed-off-by: Mark Phelps <[email protected]>

chore: fix config unit test

86375e0

Signed-off-by: Mark Phelps <[email protected]>

chore: fix golint issues

ddc5285

Signed-off-by: Mark Phelps <[email protected]>

markphelps merged commit 30f4909 into v2 May 29, 2025

markphelps deleted the v2-proposals branch May 29, 2025 12:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: V2 proposals#4237

feat: V2 proposals#4237
markphelps merged 35 commits into
v2from
v2-proposals

markphelps commented May 22, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 22, 2025 •

edited

Loading

Uh oh!

codecov Bot commented May 27, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

markphelps commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

markphelps commented May 22, 2025 •

edited

Loading

github-actions Bot commented May 22, 2025 •

edited

Loading

codecov Bot commented May 27, 2025 •

edited

Loading