Skip to content

fix(ui): v2 clean up branch selector#4236

Merged
erka merged 1 commit into
v2from
rd/v2/branch-selector
May 22, 2025
Merged

fix(ui): v2 clean up branch selector#4236
erka merged 1 commit into
v2from
rd/v2/branch-selector

Conversation

@erka

@erka erka commented May 22, 2025

Copy link
Copy Markdown
Contributor

image
image

@erka
erka requested a review from a team as a code owner May 22, 2025 15:20
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 22, 2025
@codecov

codecov Bot commented May 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2@15eaade). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #4236   +/-   ##
=====================================
  Coverage      ?   50.97%           
=====================================
  Files         ?      121           
  Lines         ?    12759           
  Branches      ?        0           
=====================================
  Hits          ?     6504           
  Misses        ?     5728           
  Partials      ?      527           
Flag Coverage Δ
unittests 50.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps markphelps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you! im working on implementing proposal based off of branches atm FYI

@erka
erka merged commit b519929 into v2 May 22, 2025
@erka
erka deleted the rd/v2/branch-selector branch May 22, 2025 16:51
@erka erka added the v2 Flipt v2 label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants