V2 branch 1#4227
Merged
Merged
Conversation
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Contributor
|
The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).
|
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
…v2-branch-1 * 'v2-branch-1' of https://github.com/flipt-io/flipt: fix(ui/v2): fix the header separator and analytics tooltip on Flags page (#4226) refactor(ui): v2 new layout for flags with analytics (#4211) chore: run gopls modernize (#4213) feat: port over redis cluster and prefix (#4212)
Signed-off-by: Mark Phelps <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #4227 +/- ##
=====================================
Coverage ? 50.97%
=====================================
Files ? 121
Lines ? 12759
Branches ? 0
=====================================
Hits ? 6504
Misses ? 5728
Partials ? 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
markphelps
marked this pull request as ready for review
May 20, 2025 12:03
dosubot
Bot
added
the
size:XXL
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
* v2: ci(v2): migrate to go tool (#4228)
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Merged
* feat: branch picker start Signed-off-by: Mark Phelps <[email protected]> * feat: make branch switcher work Signed-off-by: Mark Phelps <[email protected]> * chore: more branch work Signed-off-by: Mark Phelps <[email protected]> * feat: switch to newly created branch after branching Signed-off-by: Mark Phelps <[email protected]> * chore: styles Signed-off-by: Mark Phelps <[email protected]> * chore: regen mocks Signed-off-by: Mark Phelps <[email protected]> * chore: fix test Signed-off-by: Mark Phelps <[email protected]> --------- Signed-off-by: Mark Phelps <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of implementing the ability to branch and propose changes to environments with pull requests.
Currently its only half implemented as PR creation is not wired up with an authenticated client. Alot of this is based off of how we do it in Flipt Cloud currently, with some cleanup
If you have your environment synced with a remote Git repo you will be able to:
curl --request POST \ --url http://localhost:8080/api/v2/environments/staging/branches)We'll still need to:
Note: I also removed the code generation for the environments SDK as I dont think we need to expose the new proposal/branch stuff