Skip to content

feat: port over redis cluster and prefix#4212

Merged
markphelps merged 5 commits into
v2from
v2-redis-cluster-prefix
May 17, 2025
Merged

feat: port over redis cluster and prefix#4212
markphelps merged 5 commits into
v2from
v2-redis-cluster-prefix

Conversation

@markphelps

Copy link
Copy Markdown
Collaborator

Port over #4034 and #4035 for v2

@codecov

codecov Bot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.22124% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@4f13092). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/config/authentication.go 0.00% 11 Missing ⚠️
internal/storage/authn/redis/client.go 83.63% 7 Missing and 2 partials ⚠️
internal/storage/authn/redis/store.go 88.63% 5 Missing ⚠️
internal/cmd/authn.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #4212   +/-   ##
=====================================
  Coverage      ?   48.74%           
=====================================
  Files         ?      120           
  Lines         ?    12366           
  Branches      ?        0           
=====================================
  Hits          ?     6028           
  Misses        ?     5864           
  Partials      ?      474           
Flag Coverage Δ
unittests 48.74% <75.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps
markphelps marked this pull request as ready for review May 16, 2025 18:47
@markphelps
markphelps requested a review from a team as a code owner May 16, 2025 18:47
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 16, 2025
Signed-off-by: Mark Phelps <[email protected]>
@markphelps
markphelps merged commit f33dab3 into v2 May 17, 2025
@markphelps
markphelps deleted the v2-redis-cluster-prefix branch May 17, 2025 14:14
markphelps added a commit that referenced this pull request May 19, 2025
…v2-branch-1

* 'v2-branch-1' of https://github.com/flipt-io/flipt:
  fix(ui/v2): fix the header separator and analytics tooltip on Flags page (#4226)
  refactor(ui): v2 new layout for flags with analytics (#4211)
  chore: run gopls modernize (#4213)
  feat: port over redis cluster and prefix (#4212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant