refactor(ui): v2 new layout for flags with analytics#4211
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #4211 +/- ##
=====================================
Coverage ? 48.76%
=====================================
Files ? 120
Lines ? 12358
Branches ? 0
=====================================
Hits ? 6026
Misses ? 5859
Partials ? 473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
31576d7 to
43eb252
Compare
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
|
@markphelps somehow I can't find colors that I would prefer. Maybe you have some ideas. |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
|
@erka I change the disabled/false colors to orange and added back the bg as i quite like how the bg looks for those badges I also expanded the sparkline width to take up a bit more space in the row |
Signed-off-by: Mark Phelps <[email protected]>
|
I also updated SegmentTable One thing still left to do is make the segment key on the Segment details page look like the one on the Flag details page
|
header to show the separator only when remote configuration is configured Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
Bot
added
the
size:L
|
@markphelps Thank you for helping out with this. I changed the Segment page. I did a small tweak for a header separator so it shows only when a remote configuration is defined. |
|
Hey @erka , looks good! Although im seeing the seperator always even when the sidebar is still showing, is that intentional?
|
…v2-branch-1 * 'v2-branch-1' of https://github.com/flipt-io/flipt: fix(ui/v2): fix the header separator and analytics tooltip on Flags page (#4226) refactor(ui): v2 new layout for flags with analytics (#4211) chore: run gopls modernize (#4213) feat: port over redis cluster and prefix (#4212)
2 participants
Uh oh!
There was an error while loading. Please reload this page.