Conversation
The current `dim_model.is_tested` logic is very slow, but also is incorrect because it looks for tests from any invocation when it should just look for tests on the current invocation. I've made two changes: 1. Join on command_invocation_id for models to tests 2. Instead of joining on the surrogate key, join on the actual table columns
MiConnell
approved these changes
Oct 1, 2025
Contributor
MiConnell
left a comment
MiConnell
left a comment
There was a problem hiding this comment.
Looks good, and this is so much more performant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
dim_model.is_testedlogic is very slow, but also is incorrect because it looks for tests from any invocation when it should just look for tests on the current invocation. I've made two changes: