Update platform creation to ensure good mtimes and better cacheing#277
Closed
alexlarsson wants to merge 1 commit intoflatpak:masterfrom
Closed
Update platform creation to ensure good mtimes and better cacheing#277alexlarsson wants to merge 1 commit intoflatpak:masterfrom
alexlarsson wants to merge 1 commit intoflatpak:masterfrom
Conversation
This splits the platform creation into 3 parts: * base - create the initial directory based on the parent platform * prepare - run prepare commands and apply all changes * cleanup - apply cleanups and cleanup commands This has cacheing advantages in that prepare_commands and cleanup changes only cause the minimal amount of rebuilds. Additionally, it ensures that the mtimes are zeroed out (from the previous checkout) both when the prepare and cleanup commands are run. This is actually important, since these often generate caches (for example fontconfig ones) which rely on zeroed mtimes so they match what will be deployed.
alexlarsson
force-pushed
the
platform-mtimes
branch
from
2f7928a to
59209fd
Compare
Member
Author
|
📌 Commit 59209fd has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the platform creation into 3 parts:
This has cacheing advantages in that prepare_commands and cleanup changes
only cause the minimal amount of rebuilds.
Additionally, it ensures that the mtimes are zeroed out (from the
previous checkout) both when the prepare and cleanup commands are run.
This is actually important, since these often generate caches (for
example fontconfig ones) which rely on zeroed mtimes so they match
what will be deployed.