Skip to content

Add com.gitbutler.gitbutler#4972

Closed
honnip wants to merge 13 commits intoflathub:new-prfrom
honnip:gitbutler
Closed

Add com.gitbutler.gitbutler#4972
honnip wants to merge 13 commits intoflathub:new-prfrom
honnip:gitbutler

Conversation

@honnip
Copy link

@honnip honnip commented Feb 20, 2024

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

sources:
- type: file
dest-filename: git-butler.deb
url: https://releases.gitbutler.com/releases/release/0.10.11-640/linux/x86_64/git-butler_0.10.11_amd64.deb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this work on aarch64?

Why not building from source?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this work on aarch64?

No, this will not work. They only export x86 deb.

Why not building from source?

Blocked by flatpak/flatpak-builder-tools#383. It has pnpm deps.

@honnip honnip mentioned this pull request Feb 20, 2024
8 tasks
@bbhtt bbhtt added awaiting-changes Pull request waiting for inputs or changes from author work-in-progress Draft PRs labels Feb 20, 2024
@honnip honnip changed the title Add com.gitbutler.app Add com.gitbutler.gitbutler Feb 20, 2024
@honnip honnip marked this pull request as ready for review February 20, 2024 13:44
@honnip
Copy link
Author

honnip commented Feb 21, 2024

bot, build com.gitbutler.gitbutler

@flathubbot
Copy link

Queued test build for com.gitbutler.gitbutler.

@flathubbot
Copy link

Started test build 101852

@flathubbot
Copy link

Build 101852 failed

@hfiguiere
Copy link
Contributor

        "W: com.gitbutler.gitbutler:13: spdx-license-unknown FSL-1.0-MIT"

The license is not a known SPDX identifier

@honnip
Copy link
Author

honnip commented Feb 23, 2024

bot, build com.gitbutler.gitbutler

@flathubbot
Copy link

Queued test build for com.gitbutler.gitbutler.

@flathubbot
Copy link

Started test build 102205

@flathubbot
Copy link

Build 102205 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/84984/com.gitbutler.gitbutler.flatpakref

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed work-in-progress Draft PRs awaiting-changes Pull request waiting for inputs or changes from author labels Feb 23, 2024
@barthalion
Copy link
Member

bot, build com.gitbutler.gitbutler

@flathubbot
Copy link

Queued test build for com.gitbutler.gitbutler.

@flathubbot
Copy link

Started test build 102932

@flathubbot
Copy link

Build 102932 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85715/com.gitbutler.gitbutler.flatpakref

@barthalion
Copy link
Member

Hey @honnip, can you explain what's the relation between your gitbutler fork and the upstream one?

@honnip
Copy link
Author

honnip commented Feb 26, 2024

Not related to upstream, I was just trying to add aarch64 build.
If you're talking about ownership, there was a discussion on discord. cc @Qix-, @krlvi as they're in the relevant thread

@barthalion
Copy link
Member

/merge @Qix- @Krivi

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/com.gitbutler.gitbutler

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request ready for final review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants