I built this in the local, but the splash screen stops and shows a blank screen.

❯ flatpak run --verbose com.modrinth.ModrinthApp 
F: No installations directory in /nix/store/rzymg3pxx85c0q6kz3qvyir6058z9ink-flatpak-1.14.5/etc/flatpak/installations.d. Skipping
F: Opening system flatpak installation at path /var/lib/flatpak
F: Opening user flatpak installation at path /home/honnip/.local/share/flatpak
F: Opening user flatpak installation at path /home/honnip/.local/share/flatpak
F: Opening user flatpak installation at path /home/honnip/.local/share/flatpak
F: Opening system flatpak installation at path /var/lib/flatpak
F: /var/lib/flatpak/runtime/org.gnome.Platform/x86_64/45/57d12cbe72e28d786a210eced336f3ebcd99a229dd6dc1d55917cb9efb1ffa7d/files/lib32 does not exist
F: Cleaning up unused container id 4252358547
F: Cleaning up per-app-ID state for com.modrinth.ModrinthApp
F: Allocated instance id 3496393466
F: Add defaults in dir /com/modrinth/ModrinthApp/
F: Add locks in dir /com/modrinth/ModrinthApp/
F: Allowing wayland access
F: Allowing x11 access
F: Allowing pulseaudio access
F: Pulseaudio user configuration file '/home/honnip/.config/pulse/client.conf': Error opening file /home/honnip/.config/pulse/client.conf: No such file or directory
F: Pulseaudio user configuration file '/etc/pulse/client.conf': Error opening file /etc/pulse/client.conf: No such file or directory
F: Running '/nix/store/iad5q0b6slrm4xhr35kc9a3iyp7n1wc4-bubblewrap-0.8.0/bin/bwrap --args 40 /nix/store/x4dbnqqn1lcyymr97i74rchb611hw8kd-xdg-dbus-proxy-0.1.5/bin/xdg-dbus-proxy --args=42'
F: Running '/nix/store/iad5q0b6slrm4xhr35kc9a3iyp7n1wc4-bubblewrap-0.8.0/bin/bwrap --args 40 modrinth-app'

I built this in the local, but the splash screen stops and shows a blank screen.

it seems this log is identical to a regular launch, and i can't reproduce this locally on a fresh or subsequent launch.

i'm going to assume this is a graphics issue though; what version of mesa or the nvidia driver are you on?

vulkaninfo says Mesa 23.3.5 (LLVM 16.0.6).

#4972 also doesn't work on GNOME 45, but it does work on GNOME 42, so I might find the problem somewhere in between...

this probably has to do with using a newer version of webkitgtk then. gnome 42's older (abi v4.0) version worked perfect for me, but this version has some flickering; i figured it was just a nvidia driver bug on my end

i'm not really sure what to do here, as the version of webkitgtk in the current gnome sdk (which doesn't use abi v4.0, so incompatible with tauri) is also 2.42.5. i would prefer to follow them as much as possible (and not use an outdated or unsupported version of a browser engine), so maybe it could be best to test and report this to gnome devs upstream? after all, if it's happening with these two apps, i imagine other webkitgtk apps might have similar issues

flite needs to be added to make the Minecraft narrator work. You can use this patch (adapted from the Minecraft flatpak):

diff --git a/com.modrinth.ModrinthApp.yml b/com.modrinth.ModrinthApp.yml
index 10bb955..4d9e05f 100644
--- a/com.modrinth.ModrinthApp.yml
+++ b/com.modrinth.ModrinthApp.yml
@@ -76,6 +76,19 @@ modules:
   # for some controller mods (see https://github.com/isXander/Controlify/issues/31)
   - shared-modules/libusb/libusb.json
 
+  - name: flite
+    config-opts:
+      - --enable-shared
+    no-parallel-make: true
+    sources:
+      - type: git
+        url: https://github.com/festvox/flite.git
+        tag: v2.2
+        commit: e9e2e37c329dbe98bfeb27a1828ef9a71fa84f88
+        x-checker-data:
+          type: git
+          tag-pattern: ^v([\\d.]+)$
+
   # TODO: compile from source (preferably before the launcher supports arm on linux)
   - name: modrinth-app
     buildsystem: simple

flite needs to be added to make the Minecraft narrator work

added, thanks!

screenshots have been added and webkitgtk was updated to it's latest release to follow the gnome runtime upstream. this should be ready for another review :)

Hope I'm not intruding on anything, but what's the hold up? Been a month now lol.

Looks like we missed it

bot, build com.modrinth.ModrinthApp

Queued test build for com.modrinth.ModrinthApp.

Started test build 112556

(It takes FOREVER to build from what I've heard.)

that's because it relies on an old and incompatible version of webkitgtk.

Build 112556 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95366/com.modrinth.ModrinthApp.flatpakref

Uhhh, this normal ?

Is this working? The image not loading does not seem normal to me.

I installed the launcher, downloaded a modpack, ran the game. Works fine on my end, except said image though

Works fine on my end, except said image though

This is my experience as well. This is because (as MagmaBro said), it's an upstream issue with their usage of a discord link for this image; nothing here is wrong the packaging itself

edit: and if upstream is quick enough, we may also want to wait on a release fixing this. this may also coincide with modrinth/code#1114, which would help us with our bundling problem. i'd rather not hold up this PR if it takes too long, though.

Works fine on my end, except said image though

This is my experience as well. This is because (as MagmaBro said), upstream issue with their usage of a discord link for this image; nothing here is wrong the packaging itself

edit: and if upstream is quick enough, we may also want to wait on a release fixing this. this may also coincide with modrinth/theseus#1114, which would help us with our bundling problem. i'd rather not hold up this PR if it takes too long, though.

Just call me Magma. ;)

Hope I'm saying this correctly, but this is caused due to these images (on the Windows version too) being grabbed via Discord's cdn. Not sure why their cdn is being used in the first place anyway.

This is probably the worst idea I have. Why aren't the images in the source tree and built into program. Discord is NOT an archive of any kind. That mean Discord WILL break your software.

Uhhh, this normal ?

Hope I'm saying this correctly, but this is caused due to these images (on the Windows version too) being grabbed via Discord's cdn. Not sure why their cdn is being used in the first place anyway.

How do I fix it though ? Can I do anything about it ?

Idk if you guys ahve the same problem as me but I can't even use the app rn

Appimage on the left and flatpak on the right. I can't press "Get Started".

Also for some reason the app can't be resized to half the screen even though I'm on a vary standard 1920 x 1080 at 100% scaling. Smallest size it can be:

Last issue, the flatpak version has a weird black boder above it and the window kinda flickers when moved or resized:

@Enderteck yeah I also had to resize the window to see the button, I'm on gnome

I don't remember exactly how I did it though, try whatever shortcuts your DE has for resizing other than dragging the window borders

Uhhh, this normal ?

Hope I'm saying this correctly, but this is caused due to these images (on the Windows version too) being grabbed via Discord's cdn. Not sure why their cdn is being used in the first place anyway.

How do I fix it though ? Can I do anything about it ?

Idk if you guys ahve the same problem as me but I can't even use the app rn

Appimage on the left and flatpak on the right. I can't press "Get Started".

Also for some reason the app can't be resized to half the screen even though I'm on a vary standard 1920 x 1080 at 100% scaling. Smallest size it can be:

Last issue, the flatpak version has a weird black boder above it and the window kinda flickers when moved or resized:

which distro?
so i can scale it normally and i don't have a weird border. the only bug is the missing image, but that's not a flatpak bug. the rest works perfectly. (i also have gnome)

Fedora 39 Gnome Wayland with Nvidia Drivers. This kind of thing also happens sometimes with fullscreen games running on XWayland.

any extensions that could be at fault?

I really doubt that but I'll try to disable them when I get back to my computer. Never happened to me before.

Doesn't change a thing

i've opened modrinth/code#1116 for discussion about missing images during onboarding. i would recommend others with this issue report it there rather than here, as it's not something we can really fix or work around

bot, build com.modrinth.ModrinthApp

Queued test build for com.modrinth.ModrinthApp.

Started test build 115420

Build 115420 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/98235/com.modrinth.ModrinthApp.flatpakref

i've updated the app to the latest 0.7.1 release. this should fix the aforementioned issues with images displaying during onboarding

bot, build com.modrinth.ModrinthApp

Queued test build for com.modrinth.ModrinthApp.

Started test build 116886

Build 116886 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99705/com.modrinth.ModrinthApp.flatpakref

/merge

A repository for this submission has been created: https://github.com/flathub/com.modrinth.ModrinthApp

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!