Add com.obsproject.Studio.Plugin.NDI by tytan652 · Pull Request #4701 · flathub/flathub

tytan652 · 2023-11-15T17:38:55Z

Please confirm your submission meets all the criteria

I have read the App Requirements and App Maintenance pages.
My pull request follows the instructions at App Submission.
I have built and tested the submission locally.
I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
- It requires --system-talk-name=org.freedesktop.Avahi to enable network discovery which is already provided by OBS Studio Flatpak for historical reasons.
All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
- Request: [Request] Flatpak version of obs-ndi DistroAV/DistroAV#724 (comment)
- Answer: [Request] Flatpak version of obs-ndi DistroAV/DistroAV#724 (comment)
- The upstream contributor @paulpv wishes to have access to the repo, and also asked @Palakis to be added.
I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
- This is an OBS Studio plugin
Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)
- The libndi path fix is really Flatpak specific since it patches it to use the extra-data path

The workflow was added to replace the external-data-checker, to avoid spamming the NDI download link in extra-data.

paulpv · 2023-11-15T17:41:34Z

Thanks @tytan652 for doing this for DistroAV/DistroAV#724 !

hfiguiere · 2023-11-15T18:53:19Z

It requires --system-talk-name=org.freedesktop.Avahi to enable network discovery which is already provided by OBS Studio Flatpak for historical reasons.

There is no permissions for extensions.

hfiguiere · 2023-11-15T23:27:59Z

bot, build com.obsproject.Studio.Plugin.NDI

flathubbot · 2023-11-15T23:28:02Z

Queued test build for com.obsproject.Studio.Plugin.NDI.

flathubbot · 2023-11-15T23:29:41Z

Started test build 81867

flathubbot · 2023-11-15T23:29:45Z

Build 81867 failed

tytan652 · 2023-11-16T07:29:50Z

bot, build com.obsproject.Studio.Plugin.NDI

flathubbot · 2023-11-16T07:29:53Z

Queued test build for com.obsproject.Studio.Plugin.NDI.

bbhtt · 2023-11-16T09:02:09Z

Buildrequests seem stuck...

bot, build com.obsproject.Studio.Plugin.NDI

flathubbot · 2023-11-16T09:02:12Z

Queued test build for com.obsproject.Studio.Plugin.NDI.

flathubbot · 2023-11-16T09:02:25Z

Started test build 81951

flathubbot · 2023-11-16T09:04:47Z

Build 81951 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/64582/com.obsproject.Studio.Plugin.NDI.flatpakref

bbhtt · 2023-11-16T09:17:05Z

Seems fine, but please test. I don't use OBS.

tytan652 · 2023-11-16T09:19:45Z

Locally it works.
The test build got the test branch, OBS Studio only gets/uses stable branch extensions.

Edit: Looking at installed files, its looks okay compared to my local build.

hfiguiere · 2023-11-16T12:58:05Z

bot, build com.obsproject.Studio.Plugin.NDI

flathubbot · 2023-11-16T12:58:08Z

Queued test build for com.obsproject.Studio.Plugin.NDI.

flathubbot · 2023-11-16T12:58:20Z

Started test build 81977

flathubbot · 2023-11-16T13:00:06Z

Build 81977 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/64608/com.obsproject.Studio.Plugin.NDI.flatpakref

paulpv · 2023-11-16T19:26:39Z

I will also try myself and update this comment...

Update:

pv@m6-16g-ubuntu:~$ flatpak install --user https://dl.flathub.org/build-repo/64608/com.obsproject.Studio.Plugin.NDI.flatpakref
The application com.obsproject.Studio.Plugin.NDI depends on runtimes from:
  https://dl.flathub.org/repo/
Configure this as new remote 'flathub' [Y/n]: y


        ID                                          Branch            Op           Remote               Download
 1. [✓] com.obsproject.Studio.Plugin.NDI            test              i            ndi-origin           54.7 MB / 55.0 MB

Installation complete.
pv@m6-16g-ubuntu:~$

Yet, when I launch the flatpak installed OBS 30, I do not see the obs-ndi plugin in the UI, and in the log do not see it even attempting to load it.
https://obsproject.com/logs/FOmFQI0T0CUrxbBD

tytan652 · 2023-11-16T19:48:08Z

@paulpv, like I said the build is made with the test branch which does not work with OBS.
Once published the release will be with the stable branch so it will work in OBS.

barthalion · 2023-11-17T10:14:37Z

/merge @GeorgesStavracas

flathubbot · 2023-11-17T10:15:10Z

A repository for this submission has been created: https://github.com/flathub/com.obsproject.Studio.Plugin.NDI

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

hfiguiere changed the title ~~Add obs-ndi to Flathub~~ Add com.obsproject.Studio.Plugin.NDI Nov 15, 2023

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch 2 times, most recently from be2acc2 to 7d2aba6 Compare November 15, 2023 17:48

hfiguiere reviewed Nov 15, 2023

View reviewed changes

Comment thread com.obsproject.Studio.Plugin.NDI.metainfo.xml Outdated

bbhtt reviewed Nov 15, 2023

View reviewed changes

Comment thread com.obsproject.Studio.Plugin.NDI.metainfo.xml Outdated

Comment thread com.obsproject.Studio.Plugin.NDI.json Outdated

Comment thread avahi.json Outdated

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch from 7d2aba6 to 171e997 Compare November 15, 2023 19:16

hfiguiere reviewed Nov 15, 2023

View reviewed changes

Comment thread com.obsproject.Studio.Plugin.NDI.metainfo.xml Outdated

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch 2 times, most recently from a3a7e95 to 4b89127 Compare November 15, 2023 19:47

hfiguiere reviewed Nov 15, 2023

View reviewed changes

Comment thread com.obsproject.Studio.Plugin.NDI.json Outdated

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch from 4b89127 to 624df5f Compare November 16, 2023 07:26

bbhtt reviewed Nov 16, 2023

View reviewed changes

Comment thread com.obsproject.Studio.Plugin.NDI.json

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch from 624df5f to 526ec29 Compare November 16, 2023 09:25

Add com.obsproject.Studio.Plugin.NDI

c5158e2

tytan652 force-pushed the com.obsproject.Studio.Plugin.NDI branch from 526ec29 to c5158e2 Compare November 16, 2023 09:25

flathubbot closed this Nov 17, 2023

tytan652 mentioned this pull request Nov 17, 2023

Add upstream contributors as maintainers for com.obsproject.Studio.Plugin.NDI #4707

Closed

paulpv mentioned this pull request Nov 17, 2023

[Request] Flatpak version of obs-ndi DistroAV/DistroAV#724

Closed

tytan652 mentioned this pull request Oct 26, 2024

Add com.obsproject.Studio.Plugin.DistroAV #5753

Closed

5 tasks

Uh oh!

Conversation

tytan652 commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please confirm your submission meets all the criteria

Uh oh!

paulpv commented Nov 15, 2023

Uh oh!

Uh oh!

hfiguiere commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hfiguiere commented Nov 15, 2023

Uh oh!

flathubbot commented Nov 15, 2023

Uh oh!

flathubbot commented Nov 15, 2023

Uh oh!

flathubbot commented Nov 15, 2023

Uh oh!

Uh oh!

tytan652 commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

bbhtt commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

Uh oh!

bbhtt commented Nov 16, 2023

Uh oh!

tytan652 commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hfiguiere commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

flathubbot commented Nov 16, 2023

Uh oh!

paulpv commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tytan652 commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barthalion commented Nov 17, 2023

Uh oh!

flathubbot commented Nov 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tytan652 commented Nov 15, 2023 •

edited

Loading

hfiguiere commented Nov 15, 2023 •

edited

Loading

tytan652 commented Nov 16, 2023 •

edited

Loading

paulpv commented Nov 16, 2023 •

edited

Loading

tytan652 commented Nov 16, 2023 •

edited

Loading