Skip to content

Add zone.elk.Elk#3876

Closed
ljrk0 wants to merge 4 commits intoflathub:new-prfrom
ljrk0:zone.elk.Elk
Closed

Add zone.elk.Elk#3876
ljrk0 wants to merge 4 commits intoflathub:new-prfrom
ljrk0:zone.elk.Elk

Conversation

@ljrk0
Copy link

@ljrk0 ljrk0 commented Feb 3, 2023

Please note this is highly WIP

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@ljrk0 ljrk0 marked this pull request as draft February 3, 2023 22:10
hfiguiere
hfiguiere reviewed Feb 3, 2023
View reviewed changes
zone.elk.Elk.yml
"--share=ipc",
"--socket=fallback-x11",
"--socket=wayland",
"--device=dri"
Copy link
Contributor

@hfiguiere hfiguiere Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to have network permissions here.

Copy link
Author

@ljrk0 ljrk0 Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I noticed that when testing and added it through Flatseal 0:-)

Will fix this as well, but already put it on the TODO in the README. This is really only a draft/braindump or PoC right now. Many things aren't properly done (even the indent in the JSON is all over the place, it's not even valid JSON because of trailing commas...).

But for today I go to sleep and iterate on this later. Thanks for the initial review though as well as the help ealier!

hfiguiere
hfiguiere reviewed Feb 3, 2023
View reviewed changes
zone.elk.Elk.yml


{
"url": "https://registry.npmjs.org/@pnpm/linux-x64/-/linux-x64-7.26.0.tgz",
Copy link
Contributor

@hfiguiere hfiguiere Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so basically this will break when building aarch64.

Copy link
Author

@ljrk0 ljrk0 Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'll look into building from source or at least retrieving the binary per-arch (see README.md#TODO)

ljrk0 added 2 commits February 3, 2023 23:14
@ljrk0
Rename .yml to .json
21d9ed1 
... for some reason it was JSON but named .yml...
@ljrk0
Document TODOs
f3f1f0e
@uncomfyhalomacro
Copy link

uncomfyhalomacro commented Apr 12, 2023

any news about this?

@hfiguiere
Copy link
Contributor

hfiguiere commented Apr 12, 2023

the PR is still draft.

@ljrk0
Copy link
Author

ljrk0 commented Apr 12, 2023

Yup, schedules changed and I just got sick the second time, didn't have time to do this properly. I did get something to build ones but it couldn't log in and was some time back then. There are some tricky things with this:

  • needs a pnpm source list generator (I hacked something together)
  • tauri was(?) quite tricky itself with some old dependencies while requiring most modern Rust
  • the aforementioned login issue

@hfiguiere hfiguiere added the awaiting-changes Pull request waiting for inputs or changes from author label Aug 9, 2023
@getchoo getchoo mentioned this pull request Aug 10, 2023
Closed
7 tasks
@bbhtt bbhtt added the work-in-progress Draft PRs label Feb 13, 2024
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

This PR hasn't received any updates in a year and will be automatically closed in 30 days. If you still plan to work on this please comment or re-open the PR.

@github-actions github-actions bot added the Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify label Feb 13, 2025
@github-actions github-actions bot closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfiguiere hfiguiere hfiguiere left review comments

Assignees

No one assigned

Labels

awaiting-changes Pull request waiting for inputs or changes from author Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify work-in-progress Draft PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ljrk0 @uncomfyhalomacro @hfiguiere @bbhtt