fix(docker): enable api version negotiation to support older daemons #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Docker client initialization to support older Docker daemons by enabling API version negotiation. Instead of hardcoding API version 1.44, the clients now automatically negotiate the API version with the Docker daemon.
Key changes:
- Removed the hardcoded Docker API version constant ("1.44")
- Added
WithAPIVersionNegotiation()to bothNewEnvClient()andNewClient()functions - This change aligns with existing patterns already used in other parts of the codebase (
logs/util/docker/docker.go,inputs/keepalived/types/container/keepalived_container_collector_host.go)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.