fix(postgresql): mark up=0 and return when Ping fails #1356
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a database connectivity check using Ping() to the PostgreSQL input plugin. When the Ping fails, the plugin sets the up metric to 0 and returns early, preventing attempts to query a non-responsive database.
Key Changes:
- Added
Ping()check after opening database connection to verify connectivity before proceeding with queries - Sets
up=0metric when Ping fails to indicate database is unreachable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if err := ins.db.Ping(); err != nil { | ||
| slist.PushSample(inputName, "up", 0, tags) | ||
| log.Println("E! failed to ping postgresql:", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
The Ping check should be performed after setting the connection pool parameters (SetMaxOpenConns, SetMaxIdleConns, SetConnMaxLifetime).
The MySQL input plugin (lines 213-221 in inputs/mysql/mysql.go) follows this pattern:
- Opens database connection
- Sets connection pool parameters
- Performs Ping check
- Sets up=1
This is the recommended order because the connection pool settings should be configured before attempting to use the connection. Consider moving this Ping check to after line 172 (after SetConnMaxLifetime).
1 participant
No description provided.