添加对MySQL不同版本二进制日志查询结果的兼容处理 #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
添加对MySQL不同版本二进制日志查询结果的兼容处理
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds compatibility handling for MySQL binary log query results across different versions by supporting a 4-column result format that includes an encryption algorithm field.
Key changes:
- Added support for MySQL versions that return 4 columns from
SHOW BINARY LOGS(including an encryption algorithm column) - Introduced an
algorithmvariable to capture the encryption algorithm field in newer MySQL versions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+65
| if err := rows.Scan(&filename, &filesize, &encrypted, &algorithm); err != nil { | ||
| return |
There was a problem hiding this comment.
The error from rows.Scan is not logged before returning, which is inconsistent with other error handling in this function (see lines 20, 31, 39). Consider logging the error like: log.Println("E! failed to scan binlog row:", err) to aid debugging when this case is triggered.
Co-authored-by: Copilot <[email protected]>
Collaborator
|
Thank you @garudaen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加对MySQL不同版本二进制日志查询结果的兼容处理