feat(snmp_zabbix): expose health check settings #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes health check settings for the SNMP Zabbix input plugin, allowing users to configure health check parameters instead of using hardcoded defaults.
Key Changes:
- Added configurable health check settings (interval, timeout, retries) to the Instance struct
- Propagated these settings through the Config struct to the SNMPClientManager
- Replaced hardcoded default values with user-configurable options that fall back to defaults when not specified
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| inputs/snmp_zabbix/snmp.go | Added three new fields to the Instance struct for health check configuration and initialization logic with default values |
| inputs/snmp_zabbix/config.go | Added corresponding private fields to the Config struct and assigned values from Instance in NewConfig |
| inputs/snmp_zabbix/snmp_client.go | Updated SNMPClientManager initialization to use configurable health check settings from Config instead of hardcoded values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+38
| healthCheckInterval time.Duration | ||
| healthCheckTimeout time.Duration | ||
| healthCheckRetries int |
There was a problem hiding this comment.
Inconsistent field visibility: These health check fields are unexported (private), while other configuration fields in this struct like DebugMode and UnconnectedUDPSocket are exported (public). Consider making these fields exported for consistency, or document why they need to be private.
Suggested change
| healthCheckInterval time.Duration | |
| healthCheckTimeout time.Duration | |
| healthCheckRetries int | |
| HealthCheckInterval time.Duration | |
| HealthCheckTimeout time.Duration | |
| HealthCheckRetries int |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.